-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][pkg/translator/azure] Add missing code owner @cparkins #28651
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good, is the PR in the description correct? It looks like metadata was only modified in #25096
Oops! I saw this and didn't change it. |
Might need to add him to cmd/githubgen/allowlist.txt as well since he's not a member yet. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@cparkins can you approve the PR if you agree with being added as a code owner? |
@TylerHelmuth - Done! Wasn't even aware I could approve or how to do it 👍 |
…telemetry#28651) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This fixes inconsistency introduced with the creation of this package. In open-telemetry#25096 @cparkins was added as a code owner in the [metadata.yaml](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/azure/metadata.yaml) but not the top level `CODEOWNERS` file. Co-authored-by: Alex Boten <[email protected]>
…telemetry#28651) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This fixes inconsistency introduced with the creation of this package. In open-telemetry#25096 @cparkins was added as a code owner in the [metadata.yaml](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/azure/metadata.yaml) but not the top level `CODEOWNERS` file. Co-authored-by: Alex Boten <[email protected]>
…telemetry#28651) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This fixes inconsistency introduced with the creation of this package. In open-telemetry#25096 @cparkins was added as a code owner in the [metadata.yaml](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/azure/metadata.yaml) but not the top level `CODEOWNERS` file. Co-authored-by: Alex Boten <[email protected]>
…telemetry#28651) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This fixes inconsistency introduced with the creation of this package. In open-telemetry#25096 @cparkins was added as a code owner in the [metadata.yaml](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/azure/metadata.yaml) but not the top level `CODEOWNERS` file. Co-authored-by: Alex Boten <[email protected]>
…telemetry#28651) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This fixes inconsistency introduced with the creation of this package. In open-telemetry#25096 @cparkins was added as a code owner in the [metadata.yaml](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/azure/metadata.yaml) but not the top level `CODEOWNERS` file. Co-authored-by: Alex Boten <[email protected]>
…telemetry#28651) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This fixes inconsistency introduced with the creation of this package. In open-telemetry#25096 @cparkins was added as a code owner in the [metadata.yaml](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/azure/metadata.yaml) but not the top level `CODEOWNERS` file. Co-authored-by: Alex Boten <[email protected]>
Description:
This fixes inconsistency introduced with the creation of this package. In #25096 @cparkins was added as a code owner in the metadata.yaml but not the top level
CODEOWNERS
file.