Clarify attributes also use regex #31496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
force-pushed
the
clarify_attr_match
branch
from
42f8b4b
to
4ada4be
Compare
crobert-1
added
Skip Changelog
|
I looked into this a bit, the attributes referred to here are coming from here. There's a comment that states only Because of this, I believe the comments are simply out of date and we should update the documentation as you're doing. 👍 |
breedx-splk
force-pushed
the
clarify_attr_match
branch
from
4ada4be
to
13634e5
Compare
breedx-splk
requested review from
djaglowski,
MovieStoreGuy,
andrzej-stencel,
dashpole,
atoulme,
jmacd,
dmitryax,
codeboten,
fatsheep9146,
Aneurysm9,
TylerHelmuth,
yurishkuro,
mx-psi,
bogdandrutu,
evan-bradley,
tigrannajaryan,
jsuereth,
arminru and
songy23
as code owners
crobert-1
removed
cmd/configschema
atoulme
approved these changes
Mar 6, 2024
atoulme
added
the
ready to merge
codeboten
pushed a commit
that referenced
this pull request
Mar 12, 2024
…nality (#31517) Context: #31496 (comment) I believe strict matching was originally the only supported option for attributes, and regex was added shortly after. I believe this comment was missed with the update, so it's out of date. Refer to the referenced comment above for more context and references.
DougManton
pushed a commit
to DougManton/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
Disclaimer: I didn't actually manage find the place in the code where this happens, so please pump the brakes if this is off-base/wrong. The description of `match_type` for `regexp` does not mention attributes, but the [example config in the tests](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/processor/attributesprocessor/testdata/config.yaml#L303) looks like it uses regexp. This could lead a user to think that regex cannot be used for attribute values when reading the docs here. The docs around the attribute value also indicated "exact", which could lead a user to believe that regex wasn't supported.
DougManton
pushed a commit
to DougManton/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…nality (open-telemetry#31517) Context: open-telemetry#31496 (comment) I believe strict matching was originally the only supported option for attributes, and regex was added shortly after. I believe this comment was missed with the update, so it's out of date. Refer to the referenced comment above for more context and references.
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
Disclaimer: I didn't actually manage find the place in the code where this happens, so please pump the brakes if this is off-base/wrong. The description of `match_type` for `regexp` does not mention attributes, but the [example config in the tests](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/processor/attributesprocessor/testdata/config.yaml#L303) looks like it uses regexp. This could lead a user to think that regex cannot be used for attribute values when reading the docs here. The docs around the attribute value also indicated "exact", which could lead a user to believe that regex wasn't supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: I didn't actually manage find the place in the code where this happens, so please pump the brakes if this is off-base/wrong.
The description of
match_typeforregexpdoes not mention attributes, but the example config in the tests looks like it uses regexp. This could lead a user to think that regex cannot be used for attribute values when reading the docs here.The docs around the attribute value also indicated "exact", which could lead a user to believe that regex wasn't supported.