[chore] [receiver/elasticsearch] Use NewDefaultClientConfig instead of manual initialization #35509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skip changelog? |
29 tasks
mackjmr
reviewed
Oct 1, 2024
mackjmr
approved these changes
Oct 1, 2024
mackjmr
reviewed
Oct 2, 2024
| @@ -138,6 +140,7 @@ func TestValidateEndpoint(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestLoadConfig(t *testing.T) { | |||
| defaultTransport := http.DefaultTransport.(*http.Transport) | |||
There was a problem hiding this comment.
One last thing, can you change this to match: open-telemetry/opentelemetry-collector@aa03d76. Like that, we aren't affected if the global DefaultTransport is changed and define our own variables
There was a problem hiding this comment.
nice suggestion, changed in 506af78
rogercoll
changed the title
djaglowski
approved these changes
Oct 9, 2024
jmichalek132
pushed a commit
to jmichalek132/opentelemetry-collector-contrib
that referenced
this pull request
Oct 10, 2024
…f manual initialization (open-telemetry#35509) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Similar to open-telemetry#35452 but for the `elasticsearch` receiver. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#35457 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Similar to #35452 but for the
elasticsearchreceiver.Link to tracking Issue: #35457
Testing:
Documentation: