Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use confighttp.NewDefaultClientConfig instead of manually creating struct #35457

Open
2 of 29 tasks
mackjmr opened this issue Sep 27, 2024 · 1 comment
Open
2 of 29 tasks

Use confighttp.NewDefaultClientConfig instead of manually creating struct #35457

mackjmr opened this issue Sep 27, 2024 · 1 comment

Comments

@mackjmr
Copy link
Member

mackjmr commented Sep 27, 2024 •
edited
Loading

Component(s)

No response

Describe the issue you're reporting

Related to second point in: open-telemetry/opentelemetry-collector#9478 (comment).

Move away from manually creating confighttp.ClientConfig in favor of using confighttp.NewDefaultClientConfig.

This is necessary for the following components:

This will be done following conditions:

  • Fields that are currently different than the default will be updated after call to NewDefaultClientConfig
  • Fields that are same as default will not be set manually anymore
  • Fields that are set in the default but currently unset in above components will be either manually unset (for backwards compatibility) or will be updated to match default.

For the third point, I am unsure of which approach to follow. An example is the otlphttpexporter (#11273), where previously MaxIdleConns, MaxIdleConnsPerHost, MaxConnsPerHost and IdleConnTimeout were unset (equivalent of nil), which is different than the default which has values.

Core collector issue: open-telemetry/opentelemetry-collector#11274
@mackjmr mackjmr added the needs triage New item requiring triage label Sep 27, 2024
@mackjmr mackjmr mentioned this issue Sep 27, 2024
Closed
1 task
@ChrsMark ChrsMark mentioned this issue Sep 27, 2024
Open
@crobert-1
Copy link
Member

Removing needs triage, sounds like a good idea to me.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Sep 30, 2024
@github-actions github-actions bot mentioned this issue Oct 1, 2024
Open
@rogercoll rogercoll mentioned this issue Oct 1, 2024
Open
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this issue Oct 1, 2024
@mackjmr
[exporter/alertmanager] Use NewDefaultClientConfig instead of manuall…
c18ed36 
…y creating struct

This PR makes usage of NewDefaultClientConfig instead of manually creating the confighttp.ClientConfig struct.

Issue: open-telemetry#35457
@mackjmr mackjmr mentioned this issue Oct 1, 2024
Merged
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this issue Oct 1, 2024
@mackjmr
[exporter/datadogexporter] Use NewDefaultClientConfig instead of manu…
cb0d4b4 
…ally creating struct

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
@mackjmr mackjmr mentioned this issue Oct 1, 2024
Merged
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this issue Oct 1, 2024
@mackjmr
[exporter/influxdb] Use NewDefaultClientConfig instead of manually cr…
a782f0a 
…eating struct

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
@mackjmr mackjmr mentioned this issue Oct 1, 2024
Open
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this issue Oct 1, 2024
@mackjmr
[exporter/logzio] Use NewDefaultClientConfig instead of manually crea…
7f54e40 
…ting struct

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
@mackjmr mackjmr mentioned this issue Oct 1, 2024
Open
mx-psi pushed a commit that referenced this issue Oct 1, 2024
@mackjmr
[exporter/datadogexporter, pkg/datadog, testbed] Use NewDefaultClient…
c621e78 
…Config instead of manually creating struct (#35519)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** #35457
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this issue Oct 1, 2024
@mackjmr
[exporter/loki] Use NewDefaultClientConfig instead of manually creati…
a6e8ec0 
…ng struct

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
@mackjmr mackjmr mentioned this issue Oct 1, 2024
Open
mx-psi pushed a commit that referenced this issue Oct 1, 2024
@mackjmr
[exporter/alertmanager] Use NewDefaultClientConfig instead of manuall…
3ea141f 
…y creating struct (#35518)

**Description:** 
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** #35457
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this issue Oct 2, 2024
@mackjmr
[chore] [exporter/mezmo] Use NewDefaultClientConfig instead of manual…
49b3d08 
…ly creating struct

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
@mackjmr mackjmr mentioned this issue Oct 2, 2024
Open
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this issue Oct 2, 2024
@mackjmr
[chore] [exporter/prometheusremotewrite] Use NewDefaultClientConfig i…
9db7ca8 
…nstead of manually creating struct

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
@mackjmr mackjmr mentioned this issue Oct 2, 2024
Open
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this issue Oct 2, 2024
@mackjmr
[chore] [exporter/signalfx] Use NewDefaultClientConfig instead of man…
6d5042d 
…ually creating struct

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
@mackjmr mackjmr mentioned this issue Oct 2, 2024
Merged
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this issue Oct 2, 2024
@mackjmr
[chore] [exporter/splunkhec] Use NewDefaultClientConfig instead of ma…
52c4b7b 
…nually creating struct

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
@mackjmr mackjmr mentioned this issue Oct 2, 2024
Open
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this issue Oct 2, 2024
@mackjmr
[chore] [exporter/sumologic] Use NewDefaultClientConfig instead of ma…
02b127f 
…nually creating struct

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
@mackjmr mackjmr mentioned this issue Oct 2, 2024
Open
mx-psi pushed a commit that referenced this issue Oct 2, 2024
@mackjmr
[chore] [exporter/signalfx] Use NewDefaultClientConfig instead of man…
52f731e 
…ually creating struct (#35543)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** #35457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mackjmr @crobert-1