Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] [exporter/logzio] Use NewDefaultClientConfig instead of manually creating struct #35524

Conversation

mackjmr
Copy link
Member

@mackjmr mackjmr commented Oct 1, 2024

Description:
This PR makes usage of NewDefaultClientConfig instead of manually creating the confighttp.ClientConfig struct.

Link to tracking Issue: #35457

…ting struct

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
@mackjmr mackjmr changed the title [exporter/logzio] Use NewDefaultClientConfig instead of manually creating struct [chore] [exporter/logzio] Use NewDefaultClientConfig instead of manually creating struct Oct 2, 2024
Copy link
Contributor

@yotamloe yotamloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) Please run go mod tidy to update go.mod since your change deprecates usage of go.opentelemetry.io/collector/config/configopaque

Copy link
Contributor

@yotamloe yotamloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving, but we still need to update go.mod as I can see that the project: tidy workflow was skipped

@mackjmr
Copy link
Member Author

mackjmr commented Oct 8, 2024

@yotamloe I ran make gotidy and this resulted in no changes

@andrzej-stencel andrzej-stencel merged commit 003780f into open-telemetry:main Oct 9, 2024
155 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 9, 2024
jmichalek132 pushed a commit to jmichalek132/opentelemetry-collector-contrib that referenced this pull request Oct 10, 2024
…lly creating struct (open-telemetry#35524)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants