-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] [exporter/logzio] Use NewDefaultClientConfig instead of manually creating struct #35524
[chore] [exporter/logzio] Use NewDefaultClientConfig instead of manually creating struct #35524
Conversation
…ting struct **Description:** This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct. **Link to tracking Issue:** open-telemetry#35457
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :) Please run go mod tidy
to update go.mod
since your change deprecates usage of go.opentelemetry.io/collector/config/configopaque
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving, but we still need to update go.mod
as I can see that the project: tidy
workflow was skipped
@yotamloe I ran make gotidy and this resulted in no changes |
…lly creating struct (open-telemetry#35524) **Description:** This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct. **Link to tracking Issue:** open-telemetry#35457
Description:
This PR makes usage of
NewDefaultClientConfig
instead of manually creating the confighttp.ClientConfig struct.Link to tracking Issue: #35457