Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move processor into an internal package, in preparation for profiles #10526

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Jul 3, 2024

Description

This splits the processor package, so the APIs are in an internal package, and redefined publicly for logs/metrics/traces.
In preparation for adding profiles to the package.

Link to tracking issue

See #10375

cc @mx-psi

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 98.90110% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.28%. Comparing base (05cdcf4) to head (0bc3fd5).
Report is 1 commits behind head on main.

Files Patch % Lines
processor/internal/factory.go 97.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10526      +/-   ##
==========================================
- Coverage   92.28%   92.28%   -0.01%     
==========================================
  Files         397      399       +2     
  Lines       18723    18731       +8     
==========================================
+ Hits        17279    17285       +6     
- Misses       1085     1086       +1     
- Partials      359      360       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmathieu dmathieu marked this pull request as ready for review July 3, 2024 09:06
@dmathieu dmathieu requested review from a team and codeboten July 3, 2024 09:06
@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 10, 2024
@mx-psi mx-psi merged commit 6d72c07 into open-telemetry:main Jul 18, 2024
50 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 18, 2024
@dmathieu dmathieu deleted the internal-processor branch July 18, 2024 09:30
mx-psi pushed a commit that referenced this pull request Jul 30, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This follows
#10526,
and adds profiles support into processors.

<!-- Issue number if applicable -->
#### Link to tracking issue
See #10375

cc @mx-psi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants