-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add profiles support in processor #10691
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
force-pushed
the
processorprofiles
branch
5 times, most recently
from
July 22, 2024 09:42
48d250a
to
62515d0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10691 +/- ##
==========================================
- Coverage 92.17% 92.12% -0.06%
==========================================
Files 401 402 +1
Lines 18786 18799 +13
==========================================
+ Hits 17316 17318 +2
- Misses 1110 1121 +11
Partials 360 360 ☔ View full report in Codecov by Sentry. |
dmathieu
force-pushed
the
processorprofiles
branch
2 times, most recently
from
July 22, 2024 10:06
c5d6b9f
to
b675147
Compare
dmathieu
force-pushed
the
processorprofiles
branch
from
July 22, 2024 11:58
280c3c3
to
4f1ecf4
Compare
Moving back to draft pending #10692 (which will reduce the size of this PR). |
dmathieu
force-pushed
the
processorprofiles
branch
from
July 23, 2024 12:49
4f1ecf4
to
d451eac
Compare
This is ready for review again. |
mx-psi
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This follows #10526, and adds profiles support into processors.
Link to tracking issue
See #10375
cc @mx-psi