Introduce SampleCount to ProfilesSink #11225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
force-pushed
the
consumertest-profilessink
branch
from
d9b741f
to
baa6e42
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11225 +/- ##
=======================================
Coverage 91.79% 91.79%
=======================================
Files 422 422
Lines 20023 20029 +6
=======================================
+ Hits 18380 18386 +6
Misses 1266 1266
Partials 377 377 ☔ View full report in Codecov by Sentry. |
mx-psi
approved these changes
Sep 20, 2024
mx-psi
added a commit
that referenced
this pull request
Oct 16, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This is extracted from #11131. It adds profiles support for the epxorterhelper, so both the otlp and otlphttp exporters can support that signal. It requires #11207✅ and #11225✅ to be merged first. --------- Co-authored-by: Pablo Baeyens <[email protected]> Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an extraction from #11131.
cc @mx-psi