-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] add exporterhelperprofiles package #11226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
force-pushed
the
exporterhelperprofiles
branch
3 times, most recently
from
September 20, 2024 08:43
2c2f0ce
to
daed833
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11226 +/- ##
==========================================
- Coverage 92.15% 92.14% -0.01%
==========================================
Files 431 433 +2
Lines 20232 20389 +157
==========================================
+ Hits 18644 18787 +143
- Misses 1227 1238 +11
- Partials 361 364 +3 ☔ View full report in Codecov by Sentry. |
dmathieu
force-pushed
the
exporterhelperprofiles
branch
from
September 20, 2024 09:50
daed833
to
b740c57
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
dmathieu
force-pushed
the
exporterhelperprofiles
branch
2 times, most recently
from
October 9, 2024 14:34
d036d6a
to
3e46c28
Compare
dmathieu
force-pushed
the
exporterhelperprofiles
branch
2 times, most recently
from
October 9, 2024 15:23
81f7da9
to
53c9c54
Compare
use pipelineprofiles instead of componentprofiles
dmathieu
force-pushed
the
exporterhelperprofiles
branch
from
October 14, 2024 07:46
3826733
to
31704c6
Compare
mx-psi
approved these changes
Oct 14, 2024
mx-psi
pushed a commit
that referenced
this pull request
Oct 18, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This uses the profiles internal packages that were implemented in previous PRs to provide profiles support to the OTLP HTTP exporter. This PR requires #11226✅ to be merged first.
mx-psi
pushed a commit
that referenced
this pull request
Oct 18, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This uses the profiles internal packages that were implemented in previous PRs to provide profiles support to the OTLP exporter. This PR requires #11226✅ to be merged first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is extracted from #11131.
It adds profiles support for the epxorterhelper, so both the otlp and otlphttp exporters can support that signal.
It requires #11207✅ and #11225✅ to be merged first.