Update OTLP to 0.6.0 and use the new Span Status code #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2031 +/- ##
==========================================
+ Coverage 92.03% 92.05% +0.01%
==========================================
Files 278 278
Lines 16755 16799 +44
==========================================
+ Hits 15421 15464 +43
- Misses 916 917 +1
Partials 418 418
Continue to review full report at Codecov.
|
tigrannajaryan
force-pushed
the
feature/tigran/span-status
branch
3 times, most recently
from
e7c76fd
to
9976229
Compare
bogdandrutu
reviewed
Nov 2, 2020
tigrannajaryan
force-pushed
the
feature/tigran/span-status
branch
9 times, most recently
from
75f070a
to
05826e5
Compare
bogdandrutu
approved these changes
Nov 3, 2020
Contributes to open-telemetry#1841 - Implemented the backward compatibility logic for sending and receiving side for DeprecatedCode and Code fields according to OTLP spec. - Had to modify pdata generator to allow generating fields without setters. This is needed because the Status code field needs a custom setter logic that implements the DeprecatedCode vs Code handling. - Added tests that verify OTLP receiver behavior for Status Code/DeprecatedCode. - Added tests that verify sending/setting behavior for Status Code/DeprecatedCode for any component that uses pdata.Traces Status.SetCode(). - Modified all non-OTLP trace receivers and exporters (Jaeger, Zipkin, OpenCensus) to use the new Status code. - Modified correctness tests to use the new status Code instead of DeprecatedCode.
tigrannajaryan
force-pushed
the
feature/tigran/span-status
branch
from
05826e5
to
e5e8508
Compare
tigrannajaryan
pushed a commit
to tigrannajaryan/opentelemetry-collector-contrib
that referenced
this pull request
Nov 4, 2020
Resolves: open-telemetry/opentelemetry-collector#1841 This uses the new Span Status Code/DeprecatedCode from core repo. Changes to Span Status are described in more details in this core PR: open-telemetry/opentelemetry-collector#2031
tigrannajaryan
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Nov 5, 2020
Resolves: open-telemetry/opentelemetry-collector#1841 This uses the new Span Status Code/DeprecatedCode from core repo. Changes to Span Status are described in more details in this core PR: open-telemetry/opentelemetry-collector#2031
|
This may have introduced a bug on opentelemetry-go as linked above, could someone take a look? Thank you! |
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…y#2031) Bumps [boto3](https://github.com/boto/boto3) from 1.24.77 to 1.24.79. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.24.77...1.24.79) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1841
Implemented the backward compatibility logic for sending and receiving
side for DeprecatedCode and Code fields according to OTLP spec.
Had to modify pdata generator to allow generating fields without setters.
This is needed because the Status code field needs a custom setter logic
that implements the DeprecatedCode vs Code handling.
Added tests that verify OTLP receiver behavior for Status Code/DeprecatedCode.
Added tests that verify sending/setting behavior for Status Code/DeprecatedCode
for any component that uses pdata.Traces Status.SetCode().
Modified all non-OTLP trace receivers and exporters (Jaeger, Zipkin, OpenCensus) to use
the new Status code.
Modified correctness tests to use the new status Code instead of DeprecatedCode.