Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OTLP to 0.6.0 and use the new Span Status code #2031

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Update OTLP to 0.6.0 and use the new Span Status code #2031

merged 1 commit into from
Nov 3, 2020

Commits on Nov 3, 2020

  1. Update OTLP to 0.6.0 and use the new Span Status code 

    Contributes to open-telemetry#1841

- Implemented the backward compatibility logic for sending and receiving
  side for DeprecatedCode and Code fields according to OTLP spec.

- Had to modify pdata generator to allow generating fields without setters.
  This is needed because the Status code field needs a custom setter logic
  that implements the DeprecatedCode vs Code handling.

- Added tests that verify OTLP receiver behavior for Status Code/DeprecatedCode.

- Added tests that verify sending/setting behavior for Status Code/DeprecatedCode
  for any component that uses pdata.Traces Status.SetCode().

- Modified all non-OTLP trace receivers and exporters (Jaeger, Zipkin, OpenCensus) to use
  the new Status code.

- Modified correctness tests to use the new status Code instead of DeprecatedCode.
    Tigran Najaryan committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    e5e8508 View commit details
    Browse the repository at this point in the history