Migrate CircleCI workflows to GitHub Actions (2/3) #2298

AzfaarQureshi · 2020-12-16T22:52:54Z

Which problem is this solving?

As part of issue, this pull request migrates the loadtest, correctness and build-package jobs to GitHub Actions. windows-msi and the publish jobs will be migrated in PR 3/3

Migration Plan

We suggest having CircleCI and GitHub Action jobs run in parallel for a few weeks. After the GitHub Actions jobs are running fine for a week or so and then remove the CircleCI workflows from config.yml
cc- @alolita, @shovnik

AzfaarQureshi · 2020-12-16T22:53:54Z

.github/workflows/build-and-test.yml

+  loadtestpre:
+    runs-on: ubuntu-latest
+    outputs:
+      matrix: ${{ steps.splitloadtest.outputs.matrix }}
+    steps:
+      - name: Checkout Repo
+        uses: actions/checkout@v2


loadtestpre does some pre-processing so we can simulate CircleCI testsharding on GitHub Actions. This cuts down the runtime of loadtests from 15mins to ~5mins
This job does the following:

Get a list of all loadtest tests using make testbed-list-loadtest

Split tests into groups of two (TestIdleMode|TestBallastMemory, TestLog10kDPS|TestMetric10kDPS etc)

Create a JSON containing each test grouping. This JSON will be consumed by the strategy.matrix of the loadtest job using fromJSON(). The strategy.matrix is how we get to run the loadtests in parallel

.github/workflows/build-and-test.yml

AzfaarQureshi · 2020-12-16T22:54:19Z

.github/workflows/build-and-test.yml

+      - name: Create test result archive # some test results have invalid characters
+        if: ${{ failure() || success() }}
+        continue-on-error: true
+        run: tar -cvf test_results.tar testbed/tests/results
+      - name: Upload test results
+        if: ${{ failure() || success() }}
+        continue-on-error: true


making a tarball of the test results because some tests have filenames with invalid characters (namely the 0*0bytes test) which causes the upload action to fail.

if: ${{ failure() || success() }} this ensures that test results are uploaded even if the loadtest fails which can be useful for debugging

continue-on-error: true Sometimes (rarely, but still) the upload action fails due to a network error on github's side. This makes sure the entire job doesnt fail if the test results fail to upload

AzfaarQureshi · 2020-12-16T22:54:38Z

testbed/testbed/receivers.go

@@ -60,7 +60,7 @@ type DataReceiverBase struct {
 	Port int
 }

-const DefaultHost = "localhost"
+const DefaultHost = "127.0.0.1"


this line was causing an error with the fluentbit log test since localhost could not be resolved on the github actions runners.

AzfaarQureshi · 2020-12-16T22:54:57Z

testbed/tests/e2e_test.go

@@ -42,7 +42,7 @@ func TestIdleMode(t *testing.T) {
 	)
 	defer tc.Stop()

-	tc.SetResourceLimits(testbed.ResourceSpec{ExpectedMaxCPU: 4, ExpectedMaxRAM: 50})
+	tc.SetResourceLimits(testbed.ResourceSpec{ExpectedMaxCPU: 4, ExpectedMaxRAM: 55})


In the GitHub Action runners the RAM utilization is consistently higher (probably due to some other background processes on the GitHub machine). Loadtests don't pass unless these values are adjusted a little 😞

codecov · 2020-12-16T23:03:05Z

Codecov Report

Merging #2298 (00caf64) into master (723676e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2298   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         272      272           
  Lines       15345    15345           
=======================================
  Hits        14124    14124           
  Misses        840      840           
  Partials      381      381

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 723676e...00caf64. Read the comment docs.

.github/workflows/build-and-test.yml

bogdandrutu · 2020-12-17T23:29:36Z

.github/workflows/build-and-test.yml

+    steps:
+      - name: Checkout Repo
+        uses: actions/checkout@v2
+      - name: Setup Go
+        uses: actions/[email protected]
+        with:
+          go-version: 1.15
+      - name: Download tool binaries
+        uses: actions/download-artifact@v2
+        with:
+          name: tool-binaries
+          path: /home/runner/go/bin
+      - name: Add execute permissions to tool binaries
+        run: chmod -R +x /home/runner/go/bin
+      - name: Setup env
+        run: |
+          echo "GOPATH=$(go env GOPATH)" >> $GITHUB_ENV
+          echo "$(go env GOPATH)/bin" >> $GITHUB_PATH
+      - name: Restore module cache
+        uses: actions/cache@v2
+        env:
+          cache-name: cache-go-modules
+        with:
+          path: /home/runner/go/pkg/mod
+          key: go-pkg-mod-${{ runner.os }}-${{ hashFiles('./go.mod') }}


This code seem to be duplicated a lot between jobs, is there a way to avoid this and have a common step that all jobs will run?

Unfortunately I dont think there is a way to reuse steps across jobs as we can't use YAML anchors. It seems like the GitHub team is aware this is a pain point though and working on an alternative feature soon :/

.github/workflows/build-and-test.yml

bogdandrutu · 2020-12-18T17:45:30Z

@AzfaarQureshi there is an error in the action

Error when evaluating 'strategy' for job 'loadtest'. (Line: 161, Col: 15): Error reading JToken from JsonReader. Path '', line 0, position 0.,(Line: 161, Col: 15): Unexpected value ''

bogdandrutu · 2020-12-18T18:16:40Z

@AzfaarQureshi @shovnik I have couple more feedback about this, how can I give that to you? Is it ok for me to file issues and assign to you?

AzfaarQureshi · 2020-12-18T18:18:00Z

@bogdandrutu yup! that works 😄 or you can hit us up on gitter if thats easier

AzfaarQureshi · 2020-12-18T18:25:11Z

@bogdandrutu the workflow actually ran faster (~10 mins) when loadtest didnt depend on the binaries from cross-compile as opposed to now when its running in ~20 mins. Should we revert the change to what it was before?

bogdandrutu · 2020-12-18T19:18:38Z

@AzfaarQureshi yes please revert :D

removing sleep from common.sh removing windows-msi updating expectd ram usage removing caching moving loadtestpre into setup environment using underscore for setup-environment instead adding collector binaries and fixing setup-pre job

.github/workflows/build-and-test.yml

AzfaarQureshi requested a review from a team December 16, 2020 22:52

AzfaarQureshi commented Dec 16, 2020

View reviewed changes

.github/workflows/build-and-test.yml Outdated Show resolved Hide resolved

AzfaarQureshi commented Dec 16, 2020

View reviewed changes

shovnik mentioned this pull request Dec 17, 2020

Migrate CircleCI workflows to GitHub Actions (3/3) #2299

Merged

AzfaarQureshi force-pushed the migrating-to-gha-2 branch from 7b043ee to 82e0cdf Compare December 17, 2020 20:24

bogdandrutu reviewed Dec 17, 2020

View reviewed changes

AzfaarQureshi force-pushed the migrating-to-gha-2 branch from 5de614f to 46e2ce8 Compare December 18, 2020 16:35

AzfaarQureshi mentioned this pull request Dec 18, 2020

Adding caching to GHA setup-environment job #2305

Merged

bogdandrutu approved these changes Dec 18, 2020

View reviewed changes

.github/workflows/build-and-test.yml Outdated Show resolved Hide resolved

.github/workflows/build-and-test.yml Outdated Show resolved Hide resolved

AzfaarQureshi force-pushed the migrating-to-gha-2 branch from 17341f2 to 3e044f4 Compare December 18, 2020 17:55

AzfaarQureshi force-pushed the migrating-to-gha-2 branch from 024f180 to 408073b Compare December 18, 2020 18:17

AzfaarQureshi force-pushed the migrating-to-gha-2 branch from 408073b to 03e6ccb Compare December 18, 2020 18:41

adding remaining CI workflows

7d3665c

removing sleep from common.sh removing windows-msi updating expectd ram usage removing caching moving loadtestpre into setup environment using underscore for setup-environment instead adding collector binaries and fixing setup-pre job

AzfaarQureshi force-pushed the migrating-to-gha-2 branch from 03e6ccb to 7d3665c Compare December 18, 2020 19:22

using v1 instead

00caf64

AzfaarQureshi commented Dec 18, 2020

View reviewed changes

.github/workflows/build-and-test.yml Show resolved Hide resolved

bogdandrutu merged commit 2069851 into open-telemetry:master Dec 18, 2020

AzfaarQureshi mentioned this pull request Dec 18, 2020

GitHub Actions Cache build-tools and change all upload/download actions to @v1 open-o11y/opentelemetry-collector#41

Closed

AzfaarQureshi mentioned this pull request Dec 18, 2020

GitHub Actions Cache build-tools and change all upload/download actions to @v1 #2308

Merged

MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021

Docs: drop @v1.0.0-RCx specifier (open-telemetry#2298)

2509791

Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024

Fix Observable Counters/UpDownCounters (open-telemetry#2298)

0563a71

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate CircleCI workflows to GitHub Actions (2/3) #2298

Migrate CircleCI workflows to GitHub Actions (2/3) #2298

AzfaarQureshi commented Dec 16, 2020

AzfaarQureshi Dec 16, 2020

AzfaarQureshi Dec 16, 2020

AzfaarQureshi Dec 16, 2020

AzfaarQureshi Dec 16, 2020

codecov bot commented Dec 16, 2020 •

edited

Loading

bogdandrutu Dec 17, 2020

AzfaarQureshi Dec 18, 2020

bogdandrutu commented Dec 18, 2020

bogdandrutu commented Dec 18, 2020

AzfaarQureshi commented Dec 18, 2020 •

edited

Loading

AzfaarQureshi commented Dec 18, 2020 •

edited

Loading

bogdandrutu commented Dec 18, 2020

Migrate CircleCI workflows to GitHub Actions (2/3) #2298

Migrate CircleCI workflows to GitHub Actions (2/3) #2298

Conversation

AzfaarQureshi commented Dec 16, 2020

Which problem is this solving?

Migration Plan

AzfaarQureshi Dec 16, 2020

Choose a reason for hiding this comment

AzfaarQureshi Dec 16, 2020

Choose a reason for hiding this comment

AzfaarQureshi Dec 16, 2020

Choose a reason for hiding this comment

AzfaarQureshi Dec 16, 2020

Choose a reason for hiding this comment

codecov bot commented Dec 16, 2020 • edited Loading

Codecov Report

bogdandrutu Dec 17, 2020

Choose a reason for hiding this comment

AzfaarQureshi Dec 18, 2020

Choose a reason for hiding this comment

bogdandrutu commented Dec 18, 2020

bogdandrutu commented Dec 18, 2020

AzfaarQureshi commented Dec 18, 2020 • edited Loading

AzfaarQureshi commented Dec 18, 2020 • edited Loading

bogdandrutu commented Dec 18, 2020

codecov bot commented Dec 16, 2020 •

edited

Loading

AzfaarQureshi commented Dec 18, 2020 •

edited

Loading

AzfaarQureshi commented Dec 18, 2020 •

edited

Loading