Copy AggregationTemporality and IsMonotonic to new metric batches #4389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4389 +/- ##
==========================================
- Coverage 88.67% 88.67% -0.01%
==========================================
Files 176 176
Lines 10377 10380 +3
==========================================
+ Hits 9202 9204 +2
- Misses 947 948 +1
Partials 228 228
Continue to review full report at Codecov.
|
mx-psi
reviewed
Nov 10, 2021
| return splitNumberDataPoints(ms.Sum().DataPoints(), dest.Sum().DataPoints(), size) | ||
| case pdata.MetricDataTypeHistogram: | ||
| dest.Histogram().SetAggregationTemporality(ms.Histogram().AggregationTemporality()) |
There was a problem hiding this comment.
It would help to add a testcase for this, to avoid further regressions
There was a problem hiding this comment.
@dashpole please do a followup PR.
bogdandrutu
approved these changes
Nov 10, 2021
| return splitNumberDataPoints(ms.Sum().DataPoints(), dest.Sum().DataPoints(), size) | ||
| case pdata.MetricDataTypeHistogram: | ||
| dest.Histogram().SetAggregationTemporality(ms.Histogram().AggregationTemporality()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix a regression in which metric batches do not have aggregation temporality and IsMonotonic set for cumulative metrics. The issue was introduced in #3573, where we changed to having to copy each field from the old metric to the new one. These fields were missed, and thus get their default value when new batches of metrics were created.
I looked at the implementation of CopyTo that is used for copying metrics elsewhere to make sure I fix all issues of this type. For Sum, we are missing AggregationTemporality and IsMonotonic. We were also missing AggregationTemporality for histograms, so I added that as well. Both summary and gauges only copy data points, so the status quo is correct.
Link to tracking Issue:
Fixes #4388
Testing:
Unit testing. The test changes I made fail without the corresponding changes to metric splitting. I haven't had a chance to e2e test it yet to show that it fixes the issue I was seeing, but it seems fairly obvious that this is the correct fix for my problems.
cc @Aneurysm9