Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test and changelog follow up to batch processor descriptor fix #4396

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Nov 11, 2021

This makes sure we have full test coverage for all data types in the batch processor, and adds a changelog entry for the fix in #4389, as requested by reviewers.

@dashpole dashpole requested review from a team and tigrannajaryan November 11, 2021 00:01
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #4396 (d731386) into main (4bb261b) will increase coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4396      +/-   ##
==========================================
+ Coverage   89.52%   89.85%   +0.33%     
==========================================
  Files         176      176              
  Lines       10334    10334              
==========================================
+ Hits         9251     9286      +35     
+ Misses        845      810      -35     
  Partials      238      238              
Impacted Files Coverage Δ
processor/batchprocessor/splitmetrics.go 98.43% <0.00%> (+27.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bb261b...d731386. Read the comment docs.

@bogdandrutu bogdandrutu merged commit a9df2ae into open-telemetry:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants