initial switch to circleci #702
Conversation
lizthegrey
requested review from
bogdandrutu,
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
|
https://github.com/open-telemetry/opentelemetry-collector/settings/branch_protection_rules/5625387 will need to be changed shortly before merging this pull, to remove the Travis requirement, and to add the Circle requirement. |
|
Looks like the tests will need to be split into multiple chunks, as compiling them with test -race all in one binary exceeds the 4GB limit on CircleCI free for open source. |
|
OMG it finally passed (but took 10 min). Let's speed this up by splitting off, first, the make rules that can run independently, and then we'll do the rules that need to be sub-parallelized. |
|
Good enough for now. Some further improvements to be made to make |
|
We'll need open-telemetry/community#319 in order to set our required checks to depend upon whole workflow succeeding rather than an individual job name fyi @bogdandrutu |
|
This should be safe to merge once the CircleCI integration is added to GitHub, and once branch protection settings are changed. I'll address parallelizing the loadtests in a separate pull. |
|
@pjanotti preferences for separate pull to fix the data race, or same pull? |
|
@lizthegrey it is fine to do both on the same (I guess that this is more likely to be hit on Circle CI) |
| name: Code coverage | ||
| command: bash <(curl -s https://codecov.io/bash) | ||
|
|
||
| publish: |
There was a problem hiding this comment.
This looks good. I'll update it in a new PR after this gets merged. Thanks @pjanotti
|
now we need to adjust branch protection settings, btw |
…lemetry#702) * auto add system.type dimension to all sa receiver datapoints * don't prefix system.type with "smartagent-" * strip "collectd/", "telegraph/", etc. from system.type
Description:
Build using CircleCI, which is much faster.
-contrib already is doing this and the .circleci file is modeled after that one.
Link to tracking Issue:
Fixes #550
Fixes #711
Testing:
Ran against CircleCI.
Documentation:
README.md and CONTRIBUTING.md updated.