Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CircleCI errors: ignore if cache missing #715

Merged
merged 3 commits into from
Mar 26, 2020
Merged

Fix CircleCI errors: ignore if cache missing #715

merged 3 commits into from
Mar 26, 2020

Conversation

lizthegrey
Copy link
Member

Description:
Create a mock directory so CircleCI can persist "nothing" to the workspace if there's really nothing.

Link to tracking Issue:
#702

Testing:
Rerun CircleCI

Documentation:
n/a

@lizthegrey
Copy link
Member Author

Sorry for the breakage @bogdandrutu, this should fix it.

@lizthegrey
Copy link
Member Author

@lizthegrey
Copy link
Member Author

lizthegrey commented Mar 26, 2020

This does appear to work now, but we may need to configure OpenTelemetry org/Circle integration now.

Screenshot from 2020-03-26 14-26-18

found it, it was

GitHub Status updates
By default, we update the status of every pushed commit with GitHub's status API. If you'd like to turn this off (if, for example, this is conflicting with another service), you can do so below.

@bogdandrutu
Copy link
Member

@lizthegrey
Copy link
Member Author

@lizthegrey somehow it looks like the details redirect me to your fork in honeycombio org app.circleci.com/pipelines/github/honeycombio/opentelemetry-collector/26/workflows/a6429d20-e0e2-4198-b2ff-aa4858b6f275/jobs/66

I have fixed it, fear not :)

@lizthegrey
Copy link
Member Author

https://github.com/open-telemetry/opentelemetry-collector/pull/715/checks look good to you @bogdandrutu?

@lizthegrey lizthegrey merged commit c0dd66e into open-telemetry:master Mar 26, 2020
@lizthegrey lizthegrey deleted the lizf.fix-circle branch March 26, 2020 19:29
@lizthegrey
Copy link
Member Author

I'm going to merge this in the interest of fixing broken builds.

Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants