Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zipkin exporter should take service.name from Resource #1549

Closed
evantorrie opened this issue Feb 18, 2021 · 1 comment · Fixed by #1697
Closed

Zipkin exporter should take service.name from Resource #1549

evantorrie opened this issue Feb 18, 2021 · 1 comment · Fixed by #1697
Assignees
@XSAM
Labels
area:trace Part of OpenTelemetry tracing
Milestone
RC1

Comments

@evantorrie
Copy link
Contributor

Zipkin requires a service name to be sent with each span. Per the specification https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk_exporters/zipkin.md#service-name ,

Zipkin service name MUST be set to the value of the resource attribute: service.name. 
If no service.name is contained in a Span's Resource, it MUST be populated from the default Resource
@evantorrie evantorrie added area:trace Part of OpenTelemetry tracing pkg:exporter labels Feb 18, 2021
@MrAlias MrAlias added this to the RC1 milestone Feb 18, 2021
@XSAM XSAM self-assigned this Feb 23, 2021
This was referenced Mar 10, 2021
Merged
Closed
@jcchavezs
Copy link
Contributor

Relevant: #1695 (comment)

jcchavezs added a commit to jcchavezs/opentelemetry-go that referenced this issue Mar 12, 2021
@jcchavezs
breaking(zipkin): removes servicName from zipkin exporter.
c366bb8 
Resource detector provides a serviceName in all cases, hence we can relay on span resource to obtain the serviceName. Also this is required by the spec https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk_exporters/zipkin.md\#service-name (open-telemetry#1549).
@jcchavezs jcchavezs mentioned this issue Mar 12, 2021
Merged
Aneurysm9 added a commit that referenced this issue Mar 16, 2021
@jcchavezs @Aneurysm9
breaking(zipkin): removes servicName from zipkin exporter. (#1697)
345f264 
* breaking(zipkin): removes servicName from zipkin exporter.

Resource detector provides a serviceName in all cases, hence we can relay on span resource to obtain the serviceName. Also this is required by the spec https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk_exporters/zipkin.md\#service-name (#1549).

* docs(zipkin): adds changelog.

* chore(examples/zipkin): updates example accordingly.

Co-authored-by: Anthony Mirabella <[email protected]>
@MrAlias MrAlias mentioned this issue Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XSAM XSAM

Labels
area:trace Part of OpenTelemetry tracing
Projects
None yet
Milestone
RC1
Development

Successfully merging a pull request may close this issue.

breaking(zipkin): removes serviceName from zipkin exporter. jcchavezs/opentelemetry-go
4 participants
@jcchavezs @MrAlias @evantorrie @XSAM