-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking(zipkin): removes serviceName from zipkin exporter. #1697
breaking(zipkin): removes serviceName from zipkin exporter. #1697
Conversation
Resource detector provides a serviceName in all cases, hence we can relay on span resource to obtain the serviceName. Also this is required by the spec https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk_exporters/zipkin.md\#service-name (open-telemetry#1549).
Codecov Report
@@ Coverage Diff @@
## main #1697 +/- ##
=======================================
- Coverage 77.8% 77.8% -0.1%
=======================================
Files 130 130
Lines 6986 6988 +2
=======================================
+ Hits 5437 5438 +1
- Misses 1298 1299 +1
Partials 251 251
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My LGTM does not count, but I like giving it 👍
CHANGELOG.md
Outdated
@@ -22,6 +22,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
- `"go.opentelemetry.io/sdk/metric/controller.basic".WithPusher` is replaced with `WithExporter` to provide consistent naming across project. (#1656) | |||
- Added non-empty string check for trace `Attribute` keys. (#1659) | |||
- Add `description` to SpanStatus only when `StatusCode` is set to error. (#1662) | |||
- Removes `serviceName` parameter from Zipkin exporter and uses resource instead. (#1549) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the standard, but I see all using "Remove" here :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should move to the Removed
section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. But we should update example/zipkin/main.go
as well.
CHANGELOG.md
Outdated
@@ -22,6 +22,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
- `"go.opentelemetry.io/sdk/metric/controller.basic".WithPusher` is replaced with `WithExporter` to provide consistent naming across project. (#1656) | |||
- Added non-empty string check for trace `Attribute` keys. (#1659) | |||
- Add `description` to SpanStatus only when `StatusCode` is set to error. (#1662) | |||
- Removes `serviceName` parameter from Zipkin exporter and uses resource instead. (#1549) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should move to the Removed
section.
Done.
…On Sat, 13 Mar 2021, 02:01 Sam Xie, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Looks good. But we should update example/zipkin/main.go as well.
------------------------------
In CHANGELOG.md
<#1697 (comment)>
:
> @@ -22,6 +22,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- `"go.opentelemetry.io/sdk/metric/controller.basic".WithPusher` is replaced with `WithExporter` to provide consistent naming across project. (#1656)
- Added non-empty string check for trace `Attribute` keys. (#1659)
- Add `description` to SpanStatus only when `StatusCode` is set to error. (#1662)
+- Removes `serviceName` parameter from Zipkin exporter and uses resource instead. (#1549)
This line should move to the Removed section.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1697 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXOYAVITMPWRFOUHDMLRCTTDK2NTANCNFSM4ZC4XRWQ>
.
|
It was required for zipkin exporter but not anymore, see open-telemetry/opentelemetry-go#1697.
* chore: removes service name as parameter for exporter It was required for zipkin exporter but not anymore, see open-telemetry/opentelemetry-go#1697. * chore: adds check for Go 1.16.
Resource detector provides a serviceName in all cases, hence we can relay on span resource to obtain the serviceName. Also this is required by the spec https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk_exporters/zipkin.md\#service-name
Closes #1549