Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Resource.LabelSet #1691

Closed
MrAlias opened this issue Mar 10, 2021 · 0 comments · Fixed by #1692
Closed

Rename Resource.LabelSet #1691

MrAlias opened this issue Mar 10, 2021 · 0 comments · Fixed by #1692
Labels
area:resources Part of OpenTelemetry resources good first issue Good for newcomers help wanted Extra attention is needed pkg:SDK Related to an SDK package
Milestone
RC1

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Mar 10, 2021

Remove the old term labels and make the method name concise, rename Resource.LabelSet to Resource.Set.
@MrAlias MrAlias added help wanted Extra attention is needed good first issue Good for newcomers pkg:SDK Related to an SDK package release:required-for-ga area:resources Part of OpenTelemetry resources labels Mar 10, 2021
@MrAlias MrAlias added this to the RC1 milestone Mar 10, 2021
@MrAlias MrAlias mentioned this issue Mar 10, 2021
Closed
5 tasks
MrAlias added a commit to MrAlias/opentelemetry-go that referenced this issue Mar 10, 2021
@MrAlias
Rename resource pkg label vars and methods
9b8c76a 
The former `labels` package is now named `attributes` to conform with
the specification requirement. This removes the lingering `label` term
from the `resource` package.

Resolve open-telemetry#1691
@MrAlias MrAlias mentioned this issue Mar 10, 2021
Merged
MrAlias added a commit that referenced this issue Mar 11, 2021
@MrAlias
Rename resource pkg label vars and methods (#1692)
8b1be11 
* Rename resource pkg label vars and methods

The former `labels` package is now named `attributes` to conform with
the specification requirement. This removes the lingering `label` term
from the `resource` package.

Resolve #1691

* Update PR number in CHANGELOG

* Propagate rename to the prometheus exporter pkg
shbieng added a commit to shbieng/opentelemetry-go that referenced this issue Aug 26, 2022
@shbieng
Rename resource pkg label vars and methods (#1692)
f30ab55 
* Rename resource pkg label vars and methods

The former `labels` package is now named `attributes` to conform with
the specification requirement. This removes the lingering `label` term
from the `resource` package.

Resolve open-telemetry/opentelemetry-go#1691

* Update PR number in CHANGELOG

* Propagate rename to the prometheus exporter pkg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:resources Part of OpenTelemetry resources good first issue Good for newcomers help wanted Extra attention is needed pkg:SDK Related to an SDK package
Projects
None yet
Milestone
RC1
Development

Successfully merging a pull request may close this issue.

Rename resource pkg label vars and methods MrAlias/opentelemetry-go
1 participant
@MrAlias