Rename resource pkg label vars and methods #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The former `labels` package is now named `attributes` to conform with the specification requirement. This removes the lingering `label` term from the `resource` package. Resolve open-telemetry#1691
MrAlias
requested review from
evantorrie,
jmacd,
lizthegrey and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1692 +/- ##
=====================================
Coverage 77.7% 77.7%
=====================================
Files 130 130
Lines 6924 6924
=====================================
Hits 5384 5384
Misses 1290 1290
Partials 250 250
|
XSAM
approved these changes
Mar 11, 2021
jmacd
approved these changes
Mar 11, 2021
evantorrie
approved these changes
Mar 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former
labelspackage is now namedattributesto conform with the specification requirement. This removes the lingeringlabelterm from theresourcepackage.Resolve #1691