exporter: swap pusher for exporter #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldelossa
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
|
A rebase of: #1486 |
ldelossa
force-pushed
the
louis/swap-pusher-for-exporter
branch
2 times, most recently
from
ace12ad
to
7aba3f6
Compare
|
@MrAlias - I closed the other PR, rebased master by accident instead of main. This is the same pr as 1486 be opened against latest main branch. |
Codecov Report
@@ Coverage Diff @@
## main #1656 +/- ##
=======================================
- Coverage 77.4% 77.4% -0.1%
=======================================
Files 128 128
Lines 6705 6705
=======================================
- Hits 5192 5190 -2
- Misses 1266 1268 +2
Partials 247 247
|
Aneurysm9
approved these changes
Mar 5, 2021
MrAlias
requested changes
Mar 5, 2021
to provide consistent naming across the code base, deprecate pusher in favor of exporter naming convention. Signed-off-by: ldelossa <[email protected]>
ldelossa
force-pushed
the
louis/swap-pusher-for-exporter
branch
from
7aba3f6
to
86571cc
Compare
MrAlias
approved these changes
Mar 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to provide consistent naming across the code base, deprecate pusher in
favor of exporter naming convention.
Signed-off-by: ldelossa [email protected]