Add non-empty string check for attribute keys #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrveera
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
|
|
Codecov Report
@@ Coverage Diff @@
## main #1659 +/- ##
=====================================
Coverage 77.3% 77.3%
=====================================
Files 128 128
Lines 6682 6682
=====================================
+ Hits 5167 5169 +2
+ Misses 1268 1266 -2
Partials 247 247
|
|
@MrAlias updating CHANGELOG effected build failure. looks like there are some flaky tests. is there way to retrigger tests? |
Aneurysm9
approved these changes
Mar 5, 2021
MrAlias
reviewed
Mar 8, 2021
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
MrAlias
approved these changes
Mar 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1657