-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test flakes due to reusuable metric GC requirement #6211
Comments
I've had more trouble with these test flakes today. The last value aggregation seems to be particularly prone to non-deterministic behavior. Will need to look into the failures closer to determine if there's anything on the metrics SDK side we can to do to make the GC allocation more reliable, or whether we should relax the test constraints. I also think we don't need to run these tests on every entry of the test matrix. Similar to how we only run code coverage on the ubuntu / java LTS entry, we should be able to only run these expensive perf tests on a single entry as well. |
I'm starting to work on this now |
- Adds more leniency towards tests has less options to "mess" them and lower the allocation rate and are more prone to have variable allocation rate. - Constraints the InstrumentGarbageCollectionBenchmarkTest to run only in one specific environment out of the entire matrix
I couldn't recreate the issue locally after inspecting it and trying to run it with I created #6221 to fix both issues mentioned: lower rate and make the test run only in one matrix option. |
@asafm we've had a couple of test flakes around the the reusuable metric GC test. WDYT think about relaxing the GC reduction requirement?
The text was updated successfully, but these errors were encountered: