Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky InstrumentGarbageCollectionBenchmarkTest #6221

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

asafm
Copy link
Contributor

@asafm asafm commented Feb 11, 2024

Fixes #6211

  • Adds more leniency towards tests, has fewer options to "mess" them and lower the allocation rate, and is more prone to have a variable allocation rate.
  • Constraints the InstrumentGarbageCollectionBenchmarkTest to run only in one specific environment out of the entire matrix

- Adds more leniency towards tests has less options to "mess" them and lower the allocation rate and are more prone to have variable allocation rate.
- Constraints the InstrumentGarbageCollectionBenchmarkTest to run only in one specific environment out of the entire matrix
Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (695ed53) 91.02% compared to head (0f46f80) 91.04%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6221      +/-   ##
============================================
+ Coverage     91.02%   91.04%   +0.01%     
- Complexity     5686     5687       +1     
============================================
  Files           621      621              
  Lines         16642    16642              
  Branches       1703     1703              
============================================
+ Hits          15149    15152       +3     
+ Misses         1000      998       -2     
+ Partials        493      492       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asafm
Copy link
Contributor Author

asafm commented Feb 12, 2024

@jack-berg I had to add another file. Tell me if that's ok.

@jack-berg jack-berg merged commit 0e84508 into open-telemetry:main Feb 12, 2024
18 checks passed
@asafm asafm deleted the lower-flaky-gc-test branch February 14, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test flakes due to reusuable metric GC requirement
2 participants