Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve resource detector documentation #2055

Closed
7 tasks done
maryliag opened this issue Mar 27, 2024 · 2 comments
Closed
7 tasks done

improve resource detector documentation #2055

maryliag opened this issue Mar 27, 2024 · 2 comments

Comments

@maryliag
Copy link
Contributor

maryliag commented Mar 27, 2024

On the README of the resource detectors, there are no details about which resource attributes are being set and what are their respective keys, making it hard to identify what we have available.

Improve documentation, adding a table with the info for all resource detectors.

maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 27, 2024
Update README of Alibaba resource detector to add a table with values getting detected.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 27, 2024
Update README of Azure Resource Detector to clarify the source of the data and also remove values from the table that were not actually being set.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 28, 2024
Update README of AWS Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 28, 2024
Update README of Alibaba resource detector to add a table with values getting detected.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 28, 2024
Update README of AWS Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 28, 2024
Update README of Azure Resource Detector to clarify the source of the data and also remove values from the table that were not actually being set.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 28, 2024
Update README of Container Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 28, 2024
Update README of GCP Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 28, 2024
Update README of GCP Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 28, 2024
Update README of Instana Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 28, 2024
Update README of GitHub Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 28, 2024
Update README of GitHub Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 28, 2024
Update README of Instana Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 28, 2024
Update README of Instana Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 28, 2024
Update README of Instana Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 28, 2024
Update README of Alibaba resource detector to add a table with values getting detected.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 28, 2024
Update README of Azure Resource Detector to clarify the source of the data and also remove values from the table that were not actually being set.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 28, 2024
Update README of AWS Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 28, 2024
Update README of AWS Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 28, 2024
Update README of AWS Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 28, 2024
Update README of Container Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 28, 2024
Update README of GCP Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 28, 2024
Update README of GitHub Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 29, 2024
Update README of Azure Resource Detector to clarify the source of the data and also remove values from the table that were not actually being set.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 29, 2024
Update README of Container Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Mar 29, 2024
Update README of GCP Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Apr 2, 2024
Update README of Azure Resource Detector to clarify the source of the data and also remove values from the table that were not actually being set.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Apr 2, 2024
Update README of AWS Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Apr 2, 2024
Update README of Container Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Apr 2, 2024
Update README of GCP Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Apr 2, 2024
Update README of Instana Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Apr 2, 2024
Update README of GitHub Resource Detector to clarify the source of the data.

Part Of open-telemetry#2055

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Apr 3, 2024
Update README of AWS Resource Detector to clarifiy the source of the data and add Semantic Conventions.

Part Of open-telemetry#2055
Part Of open-telemetry#2025

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Apr 3, 2024
Update README of Azure Resource Detector to clarify the source of the data and also remove values from the table that were not actually being set.
Add Semantic conventions to README

Part Of open-telemetry#2055
Part OF open-telemetry#2025

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Apr 3, 2024
Update README of Container Resource Detector to clarify the source of the data and add Semantic Conventions.

Part Of open-telemetry#2055
Part Of open-telemetry#2025

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Apr 3, 2024
Update README of GCP Resource Detector to clarify the source of the data and add semantic conventions.

Part Of open-telemetry#2055
Part Of open-telemetry#2025

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Apr 3, 2024
Update README of Instana Resource Detector to clarify the source of the data and add Semantic conventions.

Part Of open-telemetry#2055
Part Of open-telemetry#2025

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Apr 3, 2024
Update README of Instana Resource Detector to clarify the source of the data and add Semantic conventions.

Part Of open-telemetry#2055
Part Of open-telemetry#2025

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Apr 9, 2024
Update README of Instana Resource Detector to clarify the source of the data and add Semantic conventions.

Part Of open-telemetry#2055
Part Of open-telemetry#2025

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Apr 9, 2024
Update README of GCP Resource Detector to clarify the source of the data and add semantic conventions.

Part Of open-telemetry#2055
Part Of open-telemetry#2025

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Apr 9, 2024
Update README of Container Resource Detector to clarify the source of the data and add Semantic Conventions.

Part Of open-telemetry#2055
Part Of open-telemetry#2025

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Apr 9, 2024
Update README of Azure Resource Detector to clarify the source of the data and also remove values from the table that were not actually being set.
Add Semantic conventions to README

Part Of open-telemetry#2055
Part OF open-telemetry#2025

Signed-off-by: maryliag <[email protected]>
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Apr 9, 2024
Update README of AWS Resource Detector to clarifiy the source of the data and add Semantic Conventions.

Part Of open-telemetry#2055
Part Of open-telemetry#2025

Signed-off-by: maryliag <[email protected]>
trentm pushed a commit that referenced this issue Apr 9, 2024
Update README of GCP Resource Detector to clarify the source of the data and add semantic conventions.

Part Of #2055
Part Of #2025
trentm pushed a commit that referenced this issue Apr 9, 2024
trentm pushed a commit that referenced this issue Apr 9, 2024
trentm added a commit that referenced this issue Apr 9, 2024
…tor (#2057)

Update README of Azure Resource Detector to clarify the source of the data and also remove values from the table that were not actually being set.
Add Semantic conventions to README

Refs: #2055
Refs: #2025
Signed-off-by: maryliag <[email protected]>
Co-authored-by: Jamie Danielson <[email protected]>
Co-authored-by: Trent Mick <[email protected]>
trentm pushed a commit that referenced this issue Apr 9, 2024
Update README of GitHub Resource Detector to clarify the source of the data.

Refs: #2055
Signed-off-by: maryliag <[email protected]>
@trentm
Copy link
Contributor

trentm commented Apr 9, 2024

Done now, I believe.

@trentm trentm closed this as completed Apr 9, 2024
@maryliag
Copy link
Contributor Author

@trentm thank you for all the reviews and merges!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants