docs(resource-detector-azure): update readme for azure resource detector #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
maryliag
force-pushed
the
doc-azure
branch
3 times, most recently
from
9d68ab1
to
7abca04
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2057 +/- ##
==========================================
- Coverage 90.97% 90.82% -0.16%
==========================================
Files 146 148 +2
Lines 7492 7672 +180
Branches 1502 1537 +35
==========================================
+ Hits 6816 6968 +152
- Misses 676 704 +28 |
maryliag
force-pushed
the
doc-azure
branch
3 times, most recently
from
de974a0
to
8d187d1
Compare
59 tasks
maryliag
changed the title
6 tasks
JamieDanielson
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
On the issue #1778 we discussed maybe not needing the Notes column with the key after all, but it's already here and I don't think it's necessary to do the extra work to remove it. If anything we can remove it when we update semantic conventions (if we need to), to minimize overhead.
Update README of Azure Resource Detector to clarify the source of the data and also remove values from the table that were not actually being set. Add Semantic conventions to README Part Of open-telemetry#2055 Part OF open-telemetry#2025 Signed-off-by: maryliag <[email protected]>
|
column removed |
trentm
reviewed
Apr 9, 2024
Co-authored-by: Trent Mick <[email protected]>
Co-authored-by: Jamie Danielson <[email protected]>
trentm
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes