Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add reconciliation for Collector v1beta1 CRD (#2703)" #2800

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

swiatekm
Copy link
Contributor

This reverts commit 9710eed

We want to push this back until we can include the Kubernetes distribution as the default image.

@swiatekm swiatekm marked this pull request as ready for review March 29, 2024 16:52
@swiatekm swiatekm requested a review from a team March 29, 2024 16:52
@swiatekm swiatekm added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 29, 2024
Copy link
Contributor

@jaronoff97 jaronoff97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavolloffay is this okay to you?

@pavolloffay
Copy link
Member

@swiatekm-sumo the PR needs to be rebased

@swiatekm
Copy link
Contributor Author

swiatekm commented Apr 2, 2024

@swiatekm-sumo the PR needs to be rebased

Done.

@pavolloffay pavolloffay merged commit 57024fc into open-telemetry:main Apr 3, 2024
31 checks passed
pavolloffay added a commit to pavolloffay/opentelemetry-operator that referenced this pull request Apr 5, 2024
pavolloffay added a commit to pavolloffay/opentelemetry-operator that referenced this pull request Apr 12, 2024
pavolloffay added a commit that referenced this pull request Apr 12, 2024
#2813)

* Revert "Revert" Add reconciliation for Collector v1beta1 CRD (#2703)" (#2800)"

This reverts commit 57024fc.

* Fix image

Signed-off-by: Pavol Loffay <[email protected]>

* Clarify hostport

Signed-off-by: Pavol Loffay <[email protected]>

* Fix issue after israel

Signed-off-by: Pavol Loffay <[email protected]>

* Fix

Signed-off-by: Pavol Loffay <[email protected]>

---------

Signed-off-by: Pavol Loffay <[email protected]>
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
…lemetry#2703)"… (open-telemetry#2813)

* Revert "Revert" Add reconciliation for Collector v1beta1 CRD (open-telemetry#2703)" (open-telemetry#2800)"

This reverts commit 57024fc.

* Fix image

Signed-off-by: Pavol Loffay <[email protected]>

* Clarify hostport

Signed-off-by: Pavol Loffay <[email protected]>

* Fix issue after israel

Signed-off-by: Pavol Loffay <[email protected]>

* Fix

Signed-off-by: Pavol Loffay <[email protected]>

---------

Signed-off-by: Pavol Loffay <[email protected]>
rubenvp8510 pushed a commit to rubenvp8510/opentelemetry-operator that referenced this pull request May 7, 2024
…lemetry#2703)"… (open-telemetry#2813)

* Revert "Revert" Add reconciliation for Collector v1beta1 CRD (open-telemetry#2703)" (open-telemetry#2800)"

This reverts commit 57024fc.

* Fix image

Signed-off-by: Pavol Loffay <[email protected]>

* Clarify hostport

Signed-off-by: Pavol Loffay <[email protected]>

* Fix issue after israel

Signed-off-by: Pavol Loffay <[email protected]>

* Fix

Signed-off-by: Pavol Loffay <[email protected]>

---------

Signed-off-by: Pavol Loffay <[email protected]>
@swiatekm swiatekm deleted the revert-v1beta1 branch June 27, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants