Revert "Revert" Add reconciliation for Collector v1beta1 CRD (#2703)"… #2813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
We need to remember to merge #2563 before the next release. @iblancasa can you rebase it once this PR is merged?
|
We also want to merge this after this merges right? open-telemetry/opentelemetry-collector-releases#507 |
…lemetry#2703)" (open-telemetry#2800)" This reverts commit 57024fc.
pavolloffay
force-pushed
the
v1beta1-webhook-revert
branch
from
a00e56a
to
8dd6972
Compare
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…lemetry#2703)"… (open-telemetry#2813) * Revert "Revert" Add reconciliation for Collector v1beta1 CRD (open-telemetry#2703)" (open-telemetry#2800)" This reverts commit 57024fc. * Fix image Signed-off-by: Pavol Loffay <[email protected]> * Clarify hostport Signed-off-by: Pavol Loffay <[email protected]> * Fix issue after israel Signed-off-by: Pavol Loffay <[email protected]> * Fix Signed-off-by: Pavol Loffay <[email protected]> --------- Signed-off-by: Pavol Loffay <[email protected]>
rubenvp8510
pushed a commit
to rubenvp8510/opentelemetry-operator
that referenced
this pull request
May 7, 2024
…lemetry#2703)"… (open-telemetry#2813) * Revert "Revert" Add reconciliation for Collector v1beta1 CRD (open-telemetry#2703)" (open-telemetry#2800)" This reverts commit 57024fc. * Fix image Signed-off-by: Pavol Loffay <[email protected]> * Clarify hostport Signed-off-by: Pavol Loffay <[email protected]> * Fix issue after israel Signed-off-by: Pavol Loffay <[email protected]> * Fix Signed-off-by: Pavol Loffay <[email protected]> --------- Signed-off-by: Pavol Loffay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (#2800)"
This reverts commit 57024fc.
Resolves #1907
Adds #2703
Description:
Link to tracking Issue(s):
Testing:
Documentation: