Proof that strings for enum are not backwards compatible #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
=== RUN TestDecodeAggregationTemporality
=== RUN TestDecodeAggregationTemporality/string
=== RUN TestDecodeAggregationTemporality/unknown_string
enum_test.go:45: no error expected, got: proto: (line 1:28): invalid value for enum type: "foo"
=== RUN TestDecodeAggregationTemporality/int
=== RUN TestDecodeAggregationTemporality/unknown_int
--- FAIL: TestDecodeAggregationTemporality (0.00s)
--- PASS: TestDecodeAggregationTemporality/string (0.00s)
--- FAIL: TestDecodeAggregationTemporality/unknown_string (0.00s)
--- PASS: TestDecodeAggregationTemporality/int (0.00s)
--- PASS: TestDecodeAggregationTemporality/unknown_int (0.00s)
FAIL
```
Signed-off-by: Bogdan Drutu <[email protected]>
jmacd
reviewed
Aug 17, 2022
| { | ||
| name: "string", | ||
| jsonStr: fmt.Sprintf("{\"aggregation_temporality\":\"%s\"}", | ||
| otlpmetrics.AggregationTemporality_AGGREGATION_TEMPORALITY_CUMULATIVE.String()), |
There was a problem hiding this comment.
Shouldn't you set the field to the enum value and Marshal() it?
|
@bogdandrutu Can we close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR only to be used as example for opentelemetry-proto discussion
Signed-off-by: Bogdan Drutu [email protected]