Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proof that strings for enum are not backwards compatible #81

Closed
wants to merge 1 commit into from
Closed

Proof that strings for enum are not backwards compatible #81

wants to merge 1 commit into from

Commits on Aug 17, 2022

  1. Proof that strings for enum are not backwards compatible 

    ```
=== RUN   TestDecodeAggregationTemporality
=== RUN   TestDecodeAggregationTemporality/string
=== RUN   TestDecodeAggregationTemporality/unknown_string
    enum_test.go:45: no error expected, got: proto: (line 1:28): invalid value for enum type: "foo"
=== RUN   TestDecodeAggregationTemporality/int
=== RUN   TestDecodeAggregationTemporality/unknown_int
--- FAIL: TestDecodeAggregationTemporality (0.00s)
    --- PASS: TestDecodeAggregationTemporality/string (0.00s)
    --- FAIL: TestDecodeAggregationTemporality/unknown_string (0.00s)

    --- PASS: TestDecodeAggregationTemporality/int (0.00s)
    --- PASS: TestDecodeAggregationTemporality/unknown_int (0.00s)

FAIL
```

Signed-off-by: Bogdan Drutu <[email protected]>
    @bogdandrutu
    bogdandrutu committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    1332374 View commit details
    Browse the repository at this point in the history