Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup OTLP exporter compression options, add tests #1671

Merged
merged 11 commits into from
Mar 12, 2021

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Mar 5, 2021

Description

  • Clean up OTLP exporter compression options and envvar code.
  • Added tests for this code as well.
  • Rename env vars OTEL_EXPORTER_OTLP_SPAN_* -> OTEL_EXPORTER_OTLP_TRACES_* per spec update
  • Updated and moved envvar documentation into the opentelemetry.sdk.environment_variables package
  • Fixed the changelog formatting 😄 moved to Fixed changelog formatting issues #1679

Relevant part of spec:

Supported values for OTEL_EXPORTER_OTLP_*COMPRESSION options:

  • If the value is missing, then compression is disabled.
  • gzip is the only specified compression method for now. Other options MAY be supported by language SDKs and should be documented for each particular language.

The gRPC python impl supports Deflate so I have added it as well.

Fixes #1327

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Added lots of new test cases

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of opentelemetry-instrumentation/ have changed

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@aabmass aabmass force-pushed the otlp-compression-cleanup-1327 branch from b22a69d to 034be2c Compare March 5, 2021 04:08
@aabmass aabmass changed the title cleanup OTLP exporter compression options, add tests Cleanup OTLP exporter compression options, add tests Mar 5, 2021
@aabmass aabmass force-pushed the otlp-compression-cleanup-1327 branch 2 times, most recently from cb01c20 to 1847f38 Compare March 5, 2021 04:22
@aabmass aabmass marked this pull request as ready for review March 5, 2021 04:22
@aabmass aabmass requested review from a team, codeboten and toumorokoshi and removed request for a team March 5, 2021 04:22
@aabmass aabmass force-pushed the otlp-compression-cleanup-1327 branch 2 times, most recently from da22731 to 8bf230a Compare March 5, 2021 04:34
@aabmass aabmass force-pushed the otlp-compression-cleanup-1327 branch from 8bf230a to 691fe0b Compare March 5, 2021 22:03
@aabmass aabmass force-pushed the otlp-compression-cleanup-1327 branch from 691fe0b to afe803e Compare March 8, 2021 17:11
@aabmass aabmass force-pushed the otlp-compression-cleanup-1327 branch from afe803e to 4e6e120 Compare March 8, 2021 17:24
@toumorokoshi toumorokoshi removed their request for review March 10, 2021 06:07
@aabmass aabmass requested a review from lzchen March 11, 2021 18:00
@lzchen
Copy link
Contributor

lzchen commented Mar 12, 2021

@ocelotl
Please review

@lzchen lzchen merged commit 58a8e8c into open-telemetry:main Mar 12, 2021
@aabmass aabmass deleted the otlp-compression-cleanup-1327 branch March 12, 2021 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix up tests around #1141
6 participants