-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup OTLP exporter compression options, add tests #1671
Merged
lzchen
merged 11 commits into
open-telemetry:main
from
aabmass:otlp-compression-cleanup-1327
Mar 12, 2021
Merged
Cleanup OTLP exporter compression options, add tests #1671
lzchen
merged 11 commits into
open-telemetry:main
from
aabmass:otlp-compression-cleanup-1327
Mar 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
force-pushed
the
otlp-compression-cleanup-1327
branch
from
March 5, 2021 04:08
b22a69d
to
034be2c
Compare
aabmass
changed the title
cleanup OTLP exporter compression options, add tests
Cleanup OTLP exporter compression options, add tests
Mar 5, 2021
aabmass
force-pushed
the
otlp-compression-cleanup-1327
branch
2 times, most recently
from
March 5, 2021 04:22
cb01c20
to
1847f38
Compare
aabmass
requested review from
a team,
codeboten and
toumorokoshi
and removed request for
a team
March 5, 2021 04:22
aabmass
force-pushed
the
otlp-compression-cleanup-1327
branch
2 times, most recently
from
March 5, 2021 04:34
da22731
to
8bf230a
Compare
srikanthccv
reviewed
Mar 5, 2021
exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/exporter.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/exporter.py
Show resolved
Hide resolved
exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/trace_exporter/__init__.py
Show resolved
Hide resolved
ocelotl
suggested changes
Mar 5, 2021
aabmass
force-pushed
the
otlp-compression-cleanup-1327
branch
from
March 5, 2021 22:03
8bf230a
to
691fe0b
Compare
owais
reviewed
Mar 5, 2021
exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/exporter.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/exporter.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/exporter.py
Outdated
Show resolved
Hide resolved
aabmass
force-pushed
the
otlp-compression-cleanup-1327
branch
from
March 8, 2021 17:11
691fe0b
to
afe803e
Compare
aabmass
force-pushed
the
otlp-compression-cleanup-1327
branch
from
March 8, 2021 17:24
afe803e
to
4e6e120
Compare
aabmass
force-pushed
the
otlp-compression-cleanup-1327
branch
from
March 8, 2021 17:45
d8957bc
to
e9e01f7
Compare
6 tasks
srikanthccv
approved these changes
Mar 10, 2021
lzchen
reviewed
Mar 10, 2021
exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/trace_exporter/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Mar 10, 2021
exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/exporter.py
Outdated
Show resolved
Hide resolved
lzchen
approved these changes
Mar 11, 2021
owais
approved these changes
Mar 11, 2021
codeboten
approved these changes
Mar 11, 2021
@ocelotl |
ocelotl
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OTEL_EXPORTER_OTLP_SPAN_*
->OTEL_EXPORTER_OTLP_TRACES_*
per spec updateopentelemetry.sdk.environment_variables
packageFixed the changelog formatting 😄moved to Fixed changelog formatting issues #1679Relevant part of spec:
The gRPC python impl supports
Deflate
so I have added it as well.Fixes #1327
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added lots of new test cases
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/
oropentelemetry-sdk/
The method interfaces of
opentelemetry-instrumentation/
have changedThe method interfaces of
test/util
have changedScripts in
scripts/
that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.toml
isort.cfg
.flake8
When a new
.github/CODEOWNER
is addedMajor changes to project information, such as in:
README.md
CONTRIBUTING.md
Yes. - Link to PR:
No.
Checklist: