-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial documentation for environment variables #1680
Conversation
I'm not entirely sure about this. I think a global list of all support env vars is great but I don't think it's strange that a component doesn't document in detail every config env var it supports. For example, jaeger exporter now just lists the env vars it supports without explaining what they do or how to use them (types, values, etc). I realize this is easier for us but I highly doubt it'd be better for end users to jump between pages when all they want is to refer to docs for one component. Is there any easy way we an describe these in the component docs in addition to the global list? |
I was going off of this comment mostly #1147 (comment). The links go directly to the env var documentation, which seems ok to me. Some of the envars don't apply to a specific piece, e.g.
We could put the env var documentation along with the docs to get this, they still appear in the index the same. I'm not sure if there is a way to sort of expand out the link to copy the documentation inline, I'll look into it |
f2a4dbf
to
ab4dd9c
Compare
Them linking to the other detail page is definitely nicer but I still feel having the docs inline on a page would be so much better if easily doable, otherwise this is fine. |
exporter/opentelemetry-exporter-otlp/tests/test_otlp_trace_exporter.py
Outdated
Show resolved
Hide resolved
1733705
to
395abd2
Compare
395abd2
to
3b63d57
Compare
3b63d57
to
5b217ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks this is a nice improvement and sets up a good pattern for documenting env variables.
Description
Depends on #1671, must be rebased before merge
Live demo https://aabmass.github.io/opentelemetry-python/docs-envvar-demo/exporter/otlp/otlp.html
.. envvar::
docs into the API/SDK environment variable modules.. envvar::
docstrings where they were missing, so they now show in the docsPart of #1147
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Built docs to see how it all looks. Here are some screenshots:
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/
oropentelemetry-sdk/
The method interfaces of
opentelemetry-instrumentation/
have changedThe method interfaces of
test/util
have changedScripts in
scripts/
that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.toml
isort.cfg
.flake8
When a new
.github/CODEOWNER
is addedMajor changes to project information, such as in:
README.md
CONTRIBUTING.md
Yes. - Link to PR:
No. (it can be done separate)
Checklist: