Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove attribute name/type from instrument creation for now #1594

Merged

Conversation

reyang
Copy link
Member

@reyang reyang commented Apr 2, 2021

Discussed during the 04/01/2021 Metrics API/SDK SIG Mtg:

  • Removed the optional attribute names/types from instrument creation
  • Added a small compatibility section so later we can revisit this topic and add this parameter back without breaking APIs.

@reyang reyang requested review from a team April 2, 2021 23:00
@reyang reyang added spec:metrics Related to the specification/metrics directory area:api Cross language API specification issue labels Apr 2, 2021
@jmacd jmacd merged commit f86a465 into open-telemetry:main Apr 5, 2021
@reyang reyang deleted the reyang/remove-optional-attr-name-type branch April 5, 2021 20:22
@HeinrichHartmann
Copy link

carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api Cross language API specification issue spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants