Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove attribute name/type from instrument creation for now #1594

Merged
merged 2 commits into from
Apr 5, 2021
Merged

Remove attribute name/type from instrument creation for now #1594

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cff250d
remove attribute name/type from instrument creation
reyang Apr 2, 2021
3c75893
Merge branch 'main' into reyang/remove-optional-attr-name-type
reyang Apr 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions specification/metrics/new_api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,6 @@ will have the following information:
instruments, whether it is synchronous or asynchronous
* An optional `unit of measure`
* An optional `description`
* An optional list of [`Attribute`](../common/common.md#attributes) names and
types

Instruments are associated with the Meter during creation, and are identified by
the name:
Expand Down Expand Up @@ -243,8 +241,6 @@ The API MUST accept the following parameters:
rule](#instrument-unit).
* An optional `description`, following the [instrument description
rule](#instrument-description).
* An optional list of [`Attribute`](../common/common.md#attributes) names and
types.

Here are some examples that individual language client might consider:

Expand Down Expand Up @@ -319,6 +315,14 @@ for the interaction between the API and SDK.
* A value
* [`Attributes`](../common/common.md#attributes)

## Compatibility

All the metrics components SHOULD allow new APIs to be added to existing
components without introducing breaking changes.

All the metrics APIs SHOULD allow optional parameter(s) to be added to existing
APIs without introducing breaking changes.

## Concurrency

For languages which support concurrent execution the Metrics APIs provide
Expand Down