Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cockroachdb to db.system semantic conventions #1725

Merged
merged 1 commit into from
May 28, 2021
Merged

Add cockroachdb to db.system semantic conventions #1725

merged 1 commit into from
May 28, 2021

Conversation

rcrowe
Copy link
Contributor

@rcrowe rcrowe commented May 26, 2021

Changes

Adds the CockroachDB DBMS to the list of well-known identifiers for db.system

@rcrowe rcrowe marked this pull request as ready for review May 26, 2021 22:08
@rcrowe rcrowe requested review from a team May 26, 2021 22:08
arminru
arminru approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@arminru arminru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@arminru arminru merged commit c254737 into open-telemetry:main May 28, 2021
@rcrowe rcrowe deleted the semconv-trace-crdb branch June 9, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iNikem iNikem iNikem approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@arminru arminru arminru approved these changes

Assignees

@yurishkuro yurishkuro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rcrowe @iNikem @tigrannajaryan @arminru @yurishkuro