-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the Spring Auto-Configuration doc #3900
Move the Spring Auto-Configuration doc #3900
Conversation
I think ok to go ahead and change them. We have similar linting in Microsoft docs that always gets me with auto-instrumentation --> autoinstrumentation. |
@jaydeluca I see #3903 that seems to fix the spelling issues. |
Actually, after #3903 lands, you'll be able to fix the spelling issue automatically using this command: $ npm run check:text -- --fix (You can run that command already, but you'll need to tweak a few instances of the rewritten words.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're getting closer! See inline for copyedits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the organisation / structure of this page. If you look at the TOC currently, it looks like this:
That doesn't make sense to me to have a single top-level heading with pretty much all of the page content under that single heading. As mentioned at the start of this page "this page documents the OpenTelemetry starter" so I think that we should:
- Change the page title to "Spring Boot Starter", to match the actual content of the page
- The heading "OpenTelemetry Spring starter" should be dropped
- All other headings should be promoted one level up.
@chalin There is a mistake. Thanks for having pointed this. It may have another topic. The Spring Boot page should probably only contain this section explaining when to use the Java agent or the starter: The rest of the page could propably move to another one related to starters and autoconfigurations. Perhaps it could be done in another PR? I could take care of it. |
SGTM, and I'm ok with approaching this incrementally. Please create an issue to track the required changes: you can simply create a new issue from #3900 (comment). I'll wait for my other comments to be addressed before making a (final) review pass. Thanks! |
Done: #3911 |
…e code references, fix links, other comments
I really appreciate all the help from ya'll 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
So, @jeanbisutti, this actually closes #3911?
@open-telemetry/java-approvers PTAL |
@chalin It does not close #3911. All the non-agent doc is still in the Spring Boot page. |
@open-telemetry/docs-approvers FYI, the Spring Boot page documents instrumentation features for Spring Boot and developed in the https://github.com/open-telemetry/opentelemetry-java-instrumentation repository. |
fyi @jeanbisutti is in @open-telemetry/java-instrumentation-approvers now |
Aaaaand we're in! |
thx @jaydeluca ❤️ |
(Continuation from #3758 after making a mistake rebasing)
Related to open-telemetry/opentelemetry-java-instrumentation#10083
Move and adapt the documentation Readme: main/instrumentation/spring/spring-boot-autoconfigure/README.md
after rebasing I am now getting the following textlint errors:
"Auto-configuration" is how it is referred to in the spring boot docs so I am hesitant to just go and update everything to "autoconfiguration" without checking first. @jeanbisutti Do you know how I should proceed?
Preview: https://deploy-preview-3900--opentelemetry.netlify.app/docs/languages/java/automatic/spring-boot/