Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/textlint] "Auto Config*" rewrite-rule capitalization fix #3903

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jan 31, 2024

@chalin chalin added the CI/infra CI & infrastructure label Jan 31, 2024
@chalin chalin requested review from a team January 31, 2024 08:52
@chalin chalin mentioned this pull request Jan 31, 2024
14 tasks
@chalin chalin force-pushed the chalin-im-autoconfigure-rule-tweak-2024-01-31 branch from 7e199f7 to 3a95531 Compare January 31, 2024 08:54
@chalin chalin force-pushed the chalin-im-autoconfigure-rule-tweak-2024-01-31 branch from 416732a to 632d3a0 Compare January 31, 2024 17:12
@chalin chalin mentioned this pull request Feb 1, 2024
8 tasks
@svrnm
Copy link
Member

svrnm commented Feb 1, 2024

works for me, since this mainly affects java so far, would be good to hear if this makes sense?

@chalin chalin force-pushed the chalin-im-autoconfigure-rule-tweak-2024-01-31 branch from 632d3a0 to 5c8f3dd Compare February 1, 2024 09:44
@chalin
Copy link
Contributor Author

chalin commented Feb 1, 2024

works for me, since this mainly affects java so far, would be good to hear if this makes sense?

@svrnm - the rule is already present in the TextLint config, this PR is just a fix to the rule. So, ... is this good to merge?

@jeanbisutti
Copy link
Member

Would a sentence starting with Configure would be accepted with the new rule, for example:

Configure this library in the following way:

@chalin
Copy link
Contributor Author

chalin commented Feb 1, 2024

Would a sentence starting with Configure would be accepted with the new rule, for example:

Configure this library in the following way:

@jeanbisutti - such an occurrence would not be affected by the rule.

@svrnm svrnm merged commit 387445b into open-telemetry:main Feb 1, 2024
14 checks passed
@svrnm
Copy link
Member

svrnm commented Feb 1, 2024

works for me, since this mainly affects java so far, would be good to hear if this makes sense?

@svrnm - the rule is already present in the TextLint config, this PR is just a fix to the rule. So, ... is this good to merge?

Yes :-)

@chalin chalin deleted the chalin-im-autoconfigure-rule-tweak-2024-01-31 branch February 1, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants