Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Simplify cSpell dict install and other script tweaks #5010

Merged
merged 2 commits into from
Aug 9, 2024
Merged

[CI] Simplify cSpell dict install and other script tweaks #5010

merged 2 commits into from
Aug 9, 2024

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Aug 9, 2024 •
edited
Loading

@chalin chalin added the CI/infra CI & infrastructure label Aug 9, 2024
@chalin chalin requested a review from a team August 9, 2024 13:13
@chalin chalin mentioned this pull request Aug 9, 2024
Closed
4 tasks
@chalin
Copy link
Contributor Author

chalin commented Aug 9, 2024

Note that the job reports a EBADENGINE error, but I think that we can ignore that for now, since the checking works. Let me see if I can fix that.

@chalin chalin marked this pull request as draft August 9, 2024 13:30
@chalin
Copy link
Contributor Author

chalin commented Aug 9, 2024

Fixed

@chalin chalin marked this pull request as ready for review August 9, 2024 13:49
@chalin chalin merged commit 3c3342e into open-telemetry:main Aug 9, 2024
17 checks passed
@chalin chalin deleted the chalin-im-install-dict-2024-08-09 branch August 9, 2024 13:49
@chalin chalin mentioned this pull request Aug 9, 2024
Closed
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theletterf theletterf theletterf approved these changes

Assignees
No one assigned
Labels
CI/infra CI & infrastructure
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalin @theletterf