Make client.address sampling relevant on HTTP server spans (#469)

Co-authored-by: Alexander Wert <[email protected]>
open-telemetry · Oct 31, 2023 · 8ff4ea6 · 8ff4ea6
1 parent a8535bd
commit 8ff4ea6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -46,6 +46,8 @@ release.
 - BREAKING: Make `url.scheme` opt_in for HTTP client and remove default value for
   `server.port` making it required on the client.
   ([#459](https://github.com/open-telemetry/semantic-conventions/pull/459))
+- Make `client.address` sampling relevant on HTTP server spans.
+  ([#469](https://github.com/open-telemetry/semantic-conventions/pull/469))
 
 ### Features
 

diff --git a/docs/http/http-spans.md b/docs/http/http-spans.md
@@ -368,6 +368,7 @@ SHOULD include the [application root](/docs/http/http-spans.md#http-server-defin
 
 Following attributes MUST be provided **at span creation time** (when provided at all), so they can be considered for sampling decisions:
 
+* [`client.address`](../general/attributes.md)
 * [`server.address`](../general/attributes.md)
 * [`server.port`](../general/attributes.md)
 * [`url.path`](../attributes-registry/url.md)

diff --git a/model/trace/http.yaml b/model/trace/http.yaml
@@ -65,6 +65,7 @@ groups:
         requirement_level: opt_in
         brief: Local socket port. Useful in case of a multi-port host.
       - ref: client.address
+        sampling_relevant: true
         note: >
             The IP address of the original client behind all proxies, if
             known (e.g. from [Forwarded#for](https://developer.mozilla.org/docs/Web/HTTP/Headers/Forwarded#for),