Make client.address sampling relevant on HTTP server spans
#469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
make-client-address-sampling-relevant
branch
from
7459467
to
e22c976
Compare
trask
force-pushed
the
make-client-address-sampling-relevant
branch
from
e22c976
to
4598fdc
Compare
trask
changed the title
client.address and client.port sampling relevant on HTTP server spansclient.address ampling relevant on HTTP server spans
trask
changed the title
client.address ampling relevant on HTTP server spansclient.address sampling relevant on HTTP server spans
AlexanderWert
approved these changes
Oct 29, 2023
mateuszrzeszutek
approved these changes
Oct 30, 2023
pyohannes
approved these changes
Oct 30, 2023
lmolkova
reviewed
Oct 30, 2023
lmolkova
approved these changes
Oct 30, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #463
Changes
Makes
client.addresssampling relevant on HTTP server spans as it seems useful for sampling from a specific client or address block.Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.