Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish a new release including the fix applied in #524 #533

Closed
arminru opened this issue Nov 16, 2023 · 4 comments · Fixed by #585
Closed

Publish a new release including the fix applied in #524 #533

arminru opened this issue Nov 16, 2023 · 4 comments · Fixed by #585
Assignees

Comments

@arminru
Copy link
Member

arminru commented Nov 16, 2023

Either by cherry-picking 2817a7f onto https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.23.0 and creating a 1.23.1 patch release, or by releasing all pending changes from main as 1.24.0.

@arminru
Copy link
Member Author

arminru commented Nov 17, 2023

PRs merged and patch release published: https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.23.1

@arminru
Copy link
Member Author

arminru commented Nov 17, 2023

@open-telemetry/specs-semconv-maintainers what do you think about this?

The fix PR (#524) was cherry-picked from main already but the changelog update and patched schema file from this PR will only be on release/v1.23.x and tag v1.23.1 for now.

I was thinking of copying them over to main so users can see everything at in one place but I will check with the other @open-telemetry/specs-semconv-maintainers if they agree.

Originally posted by @arminru in #538 (comment)

@joaopgrassi
Copy link
Member

The release using the "patch version" approach is published https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.23.1. The OTel website is also updated and the schema is also live: https://opentelemetry.io/schemas/1.23.1. Closing this as completed.

@arminru
Copy link
Member Author

arminru commented Nov 21, 2023

We still need to clarify if we want to copy both changes to the main branch (and subsequently future releases) too:

#533 (comment)

cc @open-telemetry/specs-semconv-maintainers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants