Cherry-pick 1.23.1 schema file (and release notes) to main #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
approved these changes
Dec 5, 2023
pellared
approved these changes
Dec 6, 2023
|
This also solves this pending issue from @arminru #533 (comment) |
joaopgrassi
approved these changes
Dec 6, 2023
arminru
approved these changes
Dec 6, 2023
pyohannes
pushed a commit
to pyohannes/semantic-conventions
that referenced
this pull request
Jan 17, 2024
…metry#585) Co-authored-by: Armin Ruech <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks #538 to main branch.
I believe the schema file at least needs to be on main, otherwise when we release 1.24.0 and the website updates to the v1.24.0 tag, the v1.23.1 schema file will no longer be available.
I personally prefer to merge the patch release notes back to main, but that is not so important if you prefer not to.
Resolves #584
Resolves #533
TODO update the patch release instructions to include this step.