Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Bare Metal Solution as a cloud platform #64

Merged
merged 3 commits into from Jun 5, 2023
Merged

Add Google Bare Metal Solution as a cloud platform #64

merged 3 commits into from Jun 5, 2023

Conversation

ghost
Copy link

@ghost ghost commented May 30, 2023

Adds Google Bare Metal Solution as an allow-listed cloud platform.
Please let me know if there's anything else I need to do to make this change properly.

@ghost ghost requested review from a team May 30, 2023 23:56
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 30, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: alex-basinov / name: Alexey Basinov (97ddee0, 56ff35c)
  • ✅ login: joaopgrassi / name: Joao Grassi (56ff35c)
  • ✅ login: jsuereth / name: Josh Suereth (cb03be4)

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved barring two things:

  1. Can you sign the CLA ?
  2. Joao's suggestion on the changelog.

Co-authored-by: Joao Grassi <[email protected]>
@ghost
Copy link
Author

ghost commented May 31, 2023

/easycla

@ghost
Copy link
Author

ghost commented May 31, 2023

  1. I am covered by a corporate CLA now. How can I tell EasyCLA bot to re-run the check ? /easycla comment doesn't seem to be doing anything.
  2. suggestion applied.

@arminru
Copy link
Member

arminru commented Jun 1, 2023

/easycla

@arminru
Copy link
Member

arminru commented Jun 1, 2023

  1. I am covered by a corporate CLA now. How can I tell EasyCLA bot to re-run the check ? /easycla comment doesn't seem to be doing anything.
  2. suggestion applied.

@alex-basinov Usually /easycla should do the trick. Also your committer email looks fine as it's the corporate one.

@jsuereth @trask Do you have a clue?

@jsuereth
Copy link
Contributor

jsuereth commented Jun 5, 2023

/easycla

@jsuereth
Copy link
Contributor

jsuereth commented Jun 5, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants