Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regenerate-initrd-posttrans: run update-bootloader --refresh for XEN #102

Merged
merged 1 commit into from
May 16, 2024

Conversation

mwilck
Copy link
Contributor

@mwilck mwilck commented May 14, 2024

On XEN configurations, the newly created initrds must be copied to
the EFI system partition. update-bootloader --refresh (actually,
grub2-mkconfig via /etc/grub.d/20_linux_xen) will take care of this.
See bsc#1223278.

Signed-off-by: Martin Wilck [email protected]

On XEN configurations, the newly created initrds must be copied to
the EFI system partition. update-bootloader --refresh (actually,
grub2-mkconfig via /etc/grub.d/20_linux_xen) will take care of this.
See bsc#1223278.

Signed-off-by: Martin Wilck <[email protected]>
@mwilck mwilck requested a review from hramrach May 14, 2024 17:07
@mwilck
Copy link
Contributor Author

mwilck commented May 14, 2024

@WenhuaChang for information

@hramrach
Copy link
Contributor

It looks generally OK but the use of || in place of if is very hard to read.

@WenhuaChang
Copy link

LGTM too.

@mwilck
Copy link
Contributor Author

mwilck commented May 15, 2024

It looks generally OK but the use of || in place of if is very hard to read.

It's a matter of taste. Personally I like this style and find it actually quite easy to understand. Also, it matches the current style of regenerate-initrd-posttrans. So, unless there are serious objections, I'd like to keep it this way for now.

@mwilck mwilck merged commit 9597ba3 into master May 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants