-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of bootloaders that follows BLS #103
Conversation
Depends on openSUSE/sdbootutil#92 |
cc @lnussel |
For reasons unknown, the obs_scm server-side service failed, showing this package as @aplanas, maybe just re-push, perhaps after applying a trivial commit msg change? |
5009a48
to
955ff46
Compare
Re-pushed |
Hm, weird, the OBS project is still broken. |
can the issue be reproduced locally? |
I squashed the commit jic |
Hm the OBS project is hosed somehow, no idea why. I'll try to fix it manually. |
@aplanas, the problem is that you changed the $ git ls-remote
From https://github.com/aplanas/suse-module-tools
2e7447774e720050841ea03eb9f8447191eeffde HEAD
5ba5b2324176ec88db514bad2f1abb19207d2ab5 refs/heads/fix_sdboot
2e7447774e720050841ea03eb9f8447191eeffde refs/heads/master If you just push the |
rebased and pushed 16.0.43 tag |
Yep, build succeeds now. Thanks! |
be33376
to
2faec67
Compare
Also depends on: openSUSE/transactional-update#122 @mwilck I changed the code a bit in the regenerate initrd post-transaction script. It is using now a new candidate feature for tukit (plugins), that will avoid the use of /dev/shm. This tukit extension has not been merged, but what do you think about the rest of the changes? |
Sorry I haven't had time for this yet. It's high on my todo list but I'm busy with lots of bug reports. |
Update the code. In rpm-script the sdbootutil detection checks also that there is no bootloader installed. If this is the case assume that sdbootutil will be installed. This is of use when generating an image, as when the kernel is installed there is still no bootloader in /boot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Alberto, thanks! I've got a few remarks.
678165b
to
09d1407
Compare
@mwilck I pushed a new commit with the changes for review. |
ping? |
@mwilck should we continue with the review? |
I think this would fix openSUSE/sdbootutil#22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for the script_rc
treatment (which you can revert to the 1st version of the patch set).
When this is done, I'll give the set a final review pass, and merge.
I will squash the commits once all is reviewed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Use sdbootutil to generate boot loader entries, install new kernels and update the initrd for new modules. Signed-off-by: Alberto Planas <[email protected]>
squashed |
No description provided.