Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a plugin mechanism to tukit #122

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Conversation

aplanas
Copy link
Collaborator

@aplanas aplanas commented May 22, 2024

No description provided.

Signed-off-by: Alberto Planas <[email protected]>
Signed-off-by: Alberto Planas <[email protected]>
@aplanas
Copy link
Collaborator Author

aplanas commented May 23, 2024

Ready for reviews!

cc @Vogtinator

@aplanas
Copy link
Collaborator Author

aplanas commented Jun 3, 2024

@laenion @Vogtinator ping? : )

Copy link
Collaborator

@laenion laenion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I like the approach - see the nits, but the place to call the plugins will have to be changed in any case.

(I'm still not sure whether it's a good idea to have the BindDir as part of the API, but I'll not complain for now ;-))

doc/tukit-plugins.md Outdated Show resolved Hide resolved
doc/tukit-plugins.md Outdated Show resolved Hide resolved
doc/tukit-plugins.md Outdated Show resolved Hide resolved
lib/Plugins.cpp Outdated Show resolved Hide resolved
lib/Plugins.cpp Outdated Show resolved Hide resolved
lib/Plugins.cpp Outdated Show resolved Hide resolved
tukit/tukit.cpp Outdated Show resolved Hide resolved
sbin/Makefile.am Show resolved Hide resolved
@aplanas aplanas force-pushed the fix_hooks branch 2 times, most recently from 88d51b3 to 2acd833 Compare June 26, 2024 15:52
@aplanas
Copy link
Collaborator Author

aplanas commented Jun 26, 2024

@laenion should be ready for another pass

@aplanas aplanas requested a review from laenion June 26, 2024 15:54
doc/tukit-plugins.md Outdated Show resolved Hide resolved
doc/tukit-plugins.md Show resolved Hide resolved
sbin/Makefile.am Show resolved Hide resolved
doc/tukit-plugins.md Show resolved Hide resolved
@laenion
Copy link
Collaborator

laenion commented Jul 1, 2024

Thanks a lot for all your work, everything is looking good now! Just one last thing: The last two commits are messed up, "tukit: move getBindDir as protected" now contains all the changes that should have gone into "tukit: add plugin mechanism"

Signed-off-by: Alberto Planas <[email protected]>
@aplanas
Copy link
Collaborator Author

aplanas commented Jul 1, 2024

The last two commits are messed up

Ah indeed. I squashed both.

@laenion laenion merged commit 05c8b51 into openSUSE:master Jul 2, 2024
Copy link
Collaborator

@laenion laenion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now, thanks a lot for your work!

@aplanas
Copy link
Collaborator Author

aplanas commented Jul 2, 2024

Thanks for your reviews @laenion. That helped a lot.

@aplanas aplanas deleted the fix_hooks branch August 5, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants