-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarification: "Location" header bevahior? #79
Comments
I think we can just defer to RFC 7231:
|
So this would mean the client needs to distinguish between the two Location formats, which is fine. Should this be called out in the dist-spec? |
Absolutely. We should add a link to the RFC in all the tables that document the headers for endpoints -- some of them are even empty for Location. |
From the spec it is not clear how the `Location` header must be set. This comment clarifies the behavior. Fixes issue opencontainers#79
From the spec it is not clear how the `Location` header must be set. This comment clarifies the behavior. Fixes issue opencontainers#79 Signed-off-by: Ramkumar Chinchani <[email protected]>
From the spec it is not clear how the `Location` header must be set. This comment clarifies the behavior. Fixes issue opencontainers#79 Signed-off-by: Ramkumar Chinchani <[email protected]>
Resolved by #206 |
As per spec, "Location" header is typically of the form:
Location: /v2//blobs/uploads/<session_id>
Also,
However, docker distribution appears to return a fully qualified "Location" header value of the form:
https://<server_ip>:<server_port>/v2//blobs/uploads/<session_id>
This behavior needs further clarification. What should be a compliant client's expectation from the server? In one case, it needs to prepend the Location header with the (scheme,address,port) and in the other, not.
The text was updated successfully, but these errors were encountered: