spec: Location can be absolute or relative
#80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcgowan
reviewed
Jan 7, 2020
spec.md
Outdated
| @@ -387,6 +387,8 @@ Uploads are started with a POST request which returns a url that can be used to | |||
|
|
|||
| The `Location` header will be used to communicate the upload location after each request. | |||
| While it won't change in the this specification, clients SHOULD use the most recent value returned by the API. | |||
| Note that the `Location` header value returned may either be absolute or relative as described in | |||
There was a problem hiding this comment.
The "Note that" doesn't seem necessary, try "The Location header value MAY be either an absolute or relative URI as described in"
There was a problem hiding this comment.
Pushed an update per comments. MUST instead of MAY makes more sense here?
From the spec it is not clear how the `Location` header must be set. This comment clarifies the behavior. Fixes issue opencontainers#79 Signed-off-by: Ramkumar Chinchani <[email protected]>
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the spec it is not clear how the
Locationheader must be set.This comment clarifies the behavior.
Fixes issue #79