Disable cookie handling by default #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe this should be the default and if there is a registry in the future which requires cookies to work, then enable it specifically. Any sort of user/session tracking is not mentioned by the spec, so disabling it by default makes sense to me. |
Set the cookie jar to nil is to disable save cookies in api contacting. Signed-off-by: wang yan <[email protected]>
wy65701436
force-pushed
the
disable-cookie
branch
from
823a56f
to
ae19cbe
Compare
wy65701436
changed the title
|
make sense, code is updated per comments, thanks. |
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the cookie jar to nil is to disable save cookies in api contacting.
Signed-off-by: wang yan [email protected]