Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.0-rc1 #190

Merged
merged 2 commits into from
Oct 6, 2020
Merged

1.0.0-rc1 #190

merged 2 commits into from
Oct 6, 2020

Conversation

vbatts
Copy link
Member

@vbatts vbatts commented Sep 30, 2020

this is for 9f55a32 to be tagged as 1.0.0-rc1
Email vote forthcoming

34 PRs merged since v1.0.0-rc0:

22583a5 (#178) Add TODO under conformance
ea7a517 (#170) read env var only once
4b80706 (#149) Update Derek's email
ae19cbe (#144) Disable cookie handling by default
771e81c (#143) Disable push teardown on Content Management workflow
1b49f74 (#133) Provide option to disable empty-layer push test
fc1ba48 (#138) Allow disabling 'pull' workflow
dca82e7 (#130) Enable user to hide skipped workflows in report
8694811 (#129) Modify manifest config to conform to image-spec
cd6b60d (#123) Improve HTML report and tidy code
7889f55 (#127) changes.md: no longer needed
bbe424c (#105) Allow range of response codes for manifest delete
6a6ee23 (#107) Clarify tags listing behavior
263eb29 (#104) Move Dockerfile to conformance directory
a5f23be (#103) add space after <
1a06550 (#98) Modify conformance Dockerfile filename
c38161c (#96) Fix misspelling of octet
7fca11e (#95) Fix typo in pagination section
2560a81 (#90) Conformance: Add CI, new tests, more report detail
174c8ce (#93) spec: quote in ticks
0383191 (#89) Add GitHub action definition for conformance tests
822d3a0 (#82) Introduce OCI Conformance Test Suite
0056e98 (#80) spec: Location can be absolute or relative
828fb62 (#78) spec: JSON formating
d8c049e (#75) spec: clarify digest algorithm
35c06bd (#76) spec: session_id is clearer than UUID
b4e9833 (#69) Remove _catalog API, reference as reserved
75485b8 (#67) Update blob patch status code to correct code
8e8fa5d (#61) Correct grammar for digest algorithm portion
d93cfa5 (#50) *: Add OCI links to spec.
51b91fe (#57) updating link to code of conduct in org repository
6b5c54d (#39) dist: check also for the path /tags
d10547b (#48) specs-go: Add ErrRegistry variable.
e58cbb4 (#35) *: copyright holder change

@jzelinskie
Copy link
Member

jzelinskie commented Sep 30, 2020

LGTM
There might be minor flaws, but this will probably shake them out quicker than not putting something in people's hands.

Approved with PullApprove

@vbatts
Copy link
Member Author

vbatts commented Oct 1, 2020

LGTM

Approved with PullApprove

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rchincha
Copy link
Contributor

rchincha commented Oct 2, 2020

LGTM

@jdolitsky jdolitsky merged commit b505e9c into master Oct 6, 2020
jdolitsky added a commit that referenced this pull request Oct 6, 2020
This reverts commit b505e9c.
@jdolitsky
Copy link
Member

I may have made a mistake by "Squash and merging" this as we lost 9f55a32 ..

@vbatts
Copy link
Member Author

vbatts commented Oct 6, 2020

ah yeah. There is no longer the commit to tag.
I would never do the squash merge workflow on github projects anyway. It also causes the gpg signatures to get lost.
Let's see how to fix this...

@jdolitsky
Copy link
Member

my apologies.. I think there is a way for us to disable that as the default merge option in GitHub settings for PRs with multi commits

@vbatts vbatts deleted the vbatts/rc1 branch October 6, 2020 14:24
@vbatts
Copy link
Member Author

vbatts commented Oct 6, 2020

fixed now. Not sure what that revert-commit reference is about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants